Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esc does not exit keyboard help dialog #16840

Open
Siderite opened this issue Jan 23, 2025 · 3 comments
Open

Esc does not exit keyboard help dialog #16840

Siderite opened this issue Jan 23, 2025 · 3 comments
Labels

Comments

@Siderite
Copy link

Exact URL of where the bug happened

https://lichess.org/analysis

Steps to reproduce the bug

  1. Press /? to get the keyboard help
  2. Press Esc to close the dialog

What did you expect to happen?

The dialog closes

What happened instead?

Ironically, I need the mouse to close the keyboard help.

Operating system

Any

Browser and version (or alternate access method)

Any

Additional information

No response

@Siderite Siderite added the bug label Jan 23, 2025
@yafred
Copy link
Contributor

yafred commented Jan 23, 2025

? closes the dialog

@Siderite
Copy link
Author

So the logic of the usage is:

  1. I don't know how to do something using the keys so I press ?
  2. The key shortcuts popup comes up
  3. I don't know how to close the popup using the keys so I press ? again
  4. Oh...!

😅 Not the best user experience.

@yafred
Copy link
Contributor

yafred commented Jan 24, 2025

I am not saying that you don't have a point (esc key is commonly used to close dialogs)

I say that, for now, you can close the dialog using ?

I am looking at adding the esc key (it's not as obvious as I expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants