fixed typo in space shape

Author: lichtkind

lib/Graphics/Toolkit/Color/Space/Format.pm

@@ -16,7 +16,7 @@ sub new {
     my $number_form = '-?(?:\d+|\d+\.\d+|.\d+)';
     my $count = $basis->count;
     $value_form = [($number_form) x $count] unless defined $value_form;
-    $value_form = [($value_form) x $count] unless ref $suffix;
+    $value_form = [($value_form) x $count] unless ref $value_form;
     $value_form = [ map {(defined $_ and $_) ? $_ : $number_form } @$value_form]; # fill missing defs with default
     return 'need an ARRAY as definition of value format' unless ref $value_form eq 'ARRAY';
     return 'definition value format has to have same length as basis (number of axis)' unless @$value_form == $count;

t/03_space_shape.t

@@ -2,7 +2,7 @@
 
 use v5.12;
 use warnings;
-use Test::More tests => 116;
+use Test::More tests => 118;
 
 BEGIN { unshift @INC, 'lib', '../lib'}
 my $module = 'Graphics::Toolkit::Color::Space::Shape';
@@ -132,6 +132,8 @@ is( $tr->[1],   1.1, 'rounded in range value to set precision');
 is( $tr->[2],   2.54, 'in range value is kept');
 
 
+is( ref $shape->in_range(1,2,3),        '',  'need array ref, not list');
+is( ref $shape->in_range({}),           '',  'need array, not other ref');
 is( ref $shape->in_range([1,2,3]), 'ARRAY',  'all values in range');
 is( ref $shape->in_range([1,2]),        '',  "not enough values");
 is( ref $shape->in_range([1,2,3,4]),    '',  "too many values");

t/04_space_format.t

@@ -2,7 +2,7 @@
 
 use v5.12;
 use warnings;
-use Test::More tests => 101;
+use Test::More tests => 107;
 
 BEGIN { unshift @INC, 'lib', '../lib'}
 my $module = 'Graphics::Toolkit::Color::Space::Format';
@@ -20,6 +20,8 @@ is( ref $obj, $module,  'one constructor argument is enough');
 my $pobj = Graphics::Toolkit::Color::Space::Format->new( $basis, '%' );
 is( ref $pobj, $module,  'used second argument: suffix');
 
+my $vobj = Graphics::Toolkit::Color::Space::Format->new( $basis, '%', '\d{2}' );
+is( ref $pobj, $module,  'used third argument argument: value format');
 
 my ($vals, $name) = $obj->deformat('abg:0,2.2,-3');
 is( ref $vals,        'ARRAY', 'could deformat values');
@@ -41,6 +43,12 @@ is( $name,     'named_string', 'found right format name');
 is( ref $vals,        'ARRAY', 'ignored inserted spaces in named string');
 is( $name,     'named_string', 'recognized named string format');
 
+($vals, $name) = $vobj->deformat(' abg: 1 %, 2 % , 3% ');
+is( ref $vals,        '', 'values need to have two digits with custom value format');
+($vals, $name) = $vobj->deformat(' abg: 11 %, 22 % , 33% ');
+is( ref $vals,        'ARRAY', 'ignored inserted spaces in named string with custom value format');
+is( $name,     'named_string', 'recognized named string format with custom value format');
+
 
 ($vals, $name) = $pobj->deformat(' abg( 1 %, 2 % , 3% ) ');
 is( ref $vals,        'ARRAY', 'ignored inserted spaces in css string');
@@ -106,6 +114,10 @@ is( $name,            'hash', 'recognized hash format with full names');
 is( $name,            'hash', 'recognized hash even when left suffixes');
 ($vals, $name) = $pobj->deformat( {ALPHA =>'1 %', BETA =>'2% ', GAMMA=>' 3%'} );
 is( $name,            'hash', 'recognized hash with suffixes');
+($vals, $name) = $vobj->deformat( {ALPHA =>'1 %', BETA =>'2% ', GAMMA=>' 3%'} );
+is( $name,             undef, 'values needed 2 digits in custom value format');
+($vals, $name) = $vobj->deformat( {ALPHA =>'21 %', BETA =>'92% ', GAMMA=>' 13%'} );
+is( $name,            'hash', 'recognized hash with suffixes and custom value format');