Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Commit 3d9d2af

Browse files
committed
Ported Dean's changes to README, removed an unnecessary println
1 parent 4de36fe commit 3d9d2af

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

README.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@ The library comes with an embedded Kafka server. To run the tests, simply run `s
2727

2828
> The embedded server is started and stopped for every test and takes quite a bit of resources. Hence it's recommended that you allocate more heap space to `sbt` when running the tests. e.g. `sbt -mem 1500`.
2929
30+
```bash
31+
$ sbt -mem 1500
32+
> +clean
33+
> +test
34+
```
35+
3036
## Type Inference and Composition
3137

3238
Here's a sample code fragment using the Scala wrapper library. Compare this with the Scala code from the same [example](https://github.com/confluentinc/kafka-streams-examples/blob/4.0.0-post/src/test/scala/io/confluent/examples/streams/StreamToTableJoinScalaIntegrationTest.scala) in Confluent's repository.
@@ -46,7 +52,10 @@ val clicksPerRegion: KTableS[String, Long] = userClicksStream
4652
.reduce(_ + _)
4753
```
4854

49-
> **Note:** The left quotes around "with" are there because `with` is a Scala keyword. This is the mechanism you use to "escape" a Scala keyword when it's used as a normal identifier in a Java library.
55+
> **Notes:**
56+
>
57+
> 1. The left quotes around "with" are there because `with` is a Scala keyword. This is the mechanism you use to "escape" a Scala keyword when it's used as a normal identifier in a Java library.
58+
> 2. Note that some methods, like `map`, take a two-argument function, for key-value pairs, rather than the more typical single argument.
5059
5160
## Better Abstraction
5261

src/test/scala/com/lightbend/kafka/scala/server/KafkaLocalServer.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ class KafkaLocalServer private (kafkaProperties: Properties, zooKeeperServer: Zo
3131
def start(): Unit = {
3232

3333
broker = KafkaServerStartable.fromProps(kafkaProperties)
34-
println(s"Broker = $broker")
3534
broker.startup()
3635
}
3736

0 commit comments

Comments
 (0)