Adds TryInto<Transaction> docs with disclaimer

sr-gi · sr-gi · commit 1a644962fe5e · 2021-09-20T11:52:15.000+02:00
See #1061 (comment)
diff --git a/lightning-block-sync/src/convert.rs b/lightning-block-sync/src/convert.rs
@@ -181,6 +181,8 @@ impl TryInto<Txid> for JsonResponse {
 	}
 }
 
+/// Converts a JSON value into a transaction. WATCH OUT! this cannot be used for zero-input transactions
+/// (e.g. createrawtransaction). See https://github.com/rust-bitcoin/rust-bitcoincore-rpc/issues/197
 impl TryInto<Transaction> for JsonResponse {
 	type Error = std::io::Error;
 	fn try_into(self) -> std::io::Result<Transaction> {

Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,8 @@ impl TryInto<Txid> for JsonResponse {`
`181`	`181`	`}`
`182`	`182`	`}`
`183`	`183`
	`184`	`+/// Converts a JSON value into a transaction. WATCH OUT! this cannot be used for zero-input transactions`
	`185`	`+/// (e.g. createrawtransaction). See https://github.com/rust-bitcoin/rust-bitcoincore-rpc/issues/197`
`184`	`186`	`impl TryInto<Transaction> for JsonResponse {`
`185`	`187`	`type Error = std::io::Error;`
`186`	`188`	`fn try_into(self) -> std::io::Result<Transaction> {`