graph/db: populate the graph cache in Start instead of during construction

In this commit, we move the graph cache population logic out of the
ChannelGraph constructor and into its Start method instead.

Author: ellemouton

graph/db/graph.go

@@ -2,6 +2,7 @@ package graphdb
 
 import (
 	"errors"
+	"fmt"
 	"sync"
 	"sync/atomic"
 	"time"
@@ -58,50 +59,18 @@ func NewChannelGraph(cfg *Config, options ...ChanGraphOption) (*ChannelGraph,
 		return nil, err
 	}
 
-	if !opts.useGraphCache {
-		return &ChannelGraph{
-			KVStore: store,
-			quit:    make(chan struct{}),
-		}, nil
+	g := &ChannelGraph{
+		KVStore: store,
+		quit:    make(chan struct{}),
 	}
 
 	// The graph cache can be turned off (e.g. for mobile users) for a
 	// speed/memory usage tradeoff.
-	graphCache := NewGraphCache(opts.preAllocCacheNumNodes)
-	startTime := time.Now()
-	log.Debugf("Populating in-memory channel graph, this might take a " +
-		"while...")
-
-	err = store.ForEachNodeCacheable(func(node route.Vertex,
-		features *lnwire.FeatureVector) error {
-
-		graphCache.AddNodeFeatures(node, features)
-
-		return nil
-	})
-	if err != nil {
-		return nil, err
+	if opts.useGraphCache {
+		g.graphCache = NewGraphCache(opts.preAllocCacheNumNodes)
 	}
 
-	err = store.ForEachChannel(func(info *models.ChannelEdgeInfo,
-		policy1, policy2 *models.ChannelEdgePolicy) error {
-
-		graphCache.AddChannel(info, policy1, policy2)
-
-		return nil
-	})
-	if err != nil {
-		return nil, err
-	}
-
-	log.Debugf("Finished populating in-memory channel graph (took %v, %s)",
-		time.Since(startTime), graphCache.Stats())
-
-	return &ChannelGraph{
-		KVStore:    store,
-		graphCache: graphCache,
-		quit:       make(chan struct{}),
-	}, nil
+	return g, nil
 }
 
 // Start kicks off any goroutines required for the ChannelGraph to function.
@@ -114,6 +83,13 @@ func (c *ChannelGraph) Start() error {
 	log.Debugf("ChannelGraph starting")
 	defer log.Debug("ChannelGraph started")
 
+	if c.graphCache != nil {
+		if err := c.populateCache(); err != nil {
+			return fmt.Errorf("could not populate the graph "+
+				"cache: %w", err)
+		}
+	}
+
 	return nil
 }
 
@@ -132,6 +108,42 @@ func (c *ChannelGraph) Stop() error {
 	return nil
 }
 
+// populateCache loads the entire channel graph into the in-memory graph cache.
+//
+// NOTE: This should only be called if the graphCache has been constructed.
+func (c *ChannelGraph) populateCache() error {
+	startTime := time.Now()
+	log.Debugf("Populating in-memory channel graph, this might take a " +
+		"while...")
+
+	err := c.KVStore.ForEachNodeCacheable(func(node route.Vertex,
+		features *lnwire.FeatureVector) error {
+
+		c.graphCache.AddNodeFeatures(node, features)
+
+		return nil
+	})
+	if err != nil {
+		return err
+	}
+
+	err = c.KVStore.ForEachChannel(func(info *models.ChannelEdgeInfo,
+		policy1, policy2 *models.ChannelEdgePolicy) error {
+
+		c.graphCache.AddChannel(info, policy1, policy2)
+
+		return nil
+	})
+	if err != nil {
+		return err
+	}
+
+	log.Debugf("Finished populating in-memory channel graph (took %v, %s)",
+		time.Since(startTime), c.graphCache.Stats())
+
+	return nil
+}
+
 // ForEachNodeDirectedChannel iterates through all channels of a given node,
 // executing the passed callback on the directed edge representing the channel
 // and its incoming policy. If the callback returns an error, then the iteration