Skip to content

CI should allow for publication of NuGet package. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
austinlparker opened this issue Oct 30, 2018 · 2 comments
Closed

CI should allow for publication of NuGet package. #32

austinlparker opened this issue Oct 30, 2018 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@austinlparker
Copy link
Contributor

Currently, the process for publishing a new release goes something like this:

  • PR is merged to master
  • Circle performs a build/test/pack workflow which outputs a nupkg file.
  • This file is downloaded then uploaded through https://nuget.org web interface.

The following would be more desirable:

  • PR is merged to master
  • When we want to do a release, master is tagged (with a semver) and pushed.
  • Circle runs a tag build, where this tag is pulled in as an environment variable.
  • The tag is set as the version of the assembly, nupkg, and tracer version tag reported to LightStep.
  • Once the package has been generated, it is uploaded to nuget.org via API.
@austinlparker austinlparker added the enhancement New feature or request label Oct 30, 2018
@austinlparker austinlparker added this to the beta milestone Oct 30, 2018
austinlparker added a commit that referenced this issue Nov 13, 2018
@austinlparker
Copy link
Contributor Author

This is blocked by libgit2/libgit2sharp#1637.

@austinlparker
Copy link
Contributor Author

Given that I haven't seen any movement on the issue I opened in that other repo, I refactored this to use a git tag via CI and some manual string janitoring to create the version string.

austinlparker added a commit that referenced this issue Nov 27, 2018
fixes #32 by having git tags create versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant