[project @ [FIX #38] Replace direct usage of NO_MATH_SUPPORT with function calls]

Author: tailor

Auth/OpenID.php

@@ -97,7 +97,7 @@
        "!\"#$%&'()*+,-./:;<=>?@[\\]^_`{|}~");
 
 if (Auth_OpenID_getMathLib() === null) {
-    define('Auth_OpenID_NO_MATH_SUPPORT', true);
+    Auth_OpenID_setNoMathSupport();
 }
 
 /**
@@ -574,4 +574,4 @@ function update(&$dest, &$src)
         }
     }
 }
-?>
+?>

Auth/OpenID/Association.php

@@ -423,7 +423,7 @@ function Auth_OpenID_getDefaultAssociationOrder()
 {
     $order = array();
 
-    if (!defined('Auth_OpenID_NO_MATH_SUPPORT')) {
+    if (!Auth_OpenID_noMathSupport()) {
         $order[] = array('HMAC-SHA1', 'DH-SHA1');
 
         if (Auth_OpenID_HMACSHA256_SUPPORTED) {

Auth/OpenID/BigMath.php

@@ -427,7 +427,7 @@ function &Auth_OpenID_getMathLib()
         return $lib;
     }
 
-    if (defined('Auth_OpenID_NO_MATH_SUPPORT')) {
+    if (Auth_OpenID_noMathSupport()) {
         $null = null;
         return $null;
     }
@@ -443,7 +443,7 @@ function &Auth_OpenID_getMathLib()
         }
         $triedstr = implode(", ", $tried);
 
-        define('Auth_OpenID_NO_MATH_SUPPORT', true);
+        Auth_OpenID_setNoMathSupport();
 
         $result = null;
         return $result;
@@ -456,4 +456,16 @@ function &Auth_OpenID_getMathLib()
     return $lib;
 }
 
+function Auth_OpenID_setNoMathSupport()
+{
+    if (!defined('Auth_OpenID_NO_MATH_SUPPORT')) {
+        define('Auth_OpenID_NO_MATH_SUPPORT', true);
+    }
+}
+
+function Auth_OpenID_noMathSupport()
+{
+    return defined('Auth_OpenID_NO_MATH_SUPPORT');
+}
+
 ?>

examples/detect.php

@@ -194,8 +194,9 @@ function detect_math($r, &$out)
         $out .= $r->ol(array(
             'Install the ' . $gmp_lnk . ' PHP extension',
             'Install the ' . $bc_lnk . ' PHP extension',
-            'If your site is low-security, define ' .
-            'Auth_OpenID_NO_MATH_SUPPORT. The library will function, but ' .
+            'If your site is low-security, call ' .
+            'Auth_OpenID_setNoMathSupport(), defined in Auth/OpenID/BigMath.php. ',
+	    'The library will function, but ' .
             'the security of your OpenID server will depend on the ' .
             'security of the network links involved. If you are only ' .
             'using consumer support, you should still be able to operate ' .