pkg/qemu: validate VNL more strictly

Signed-off-by: Akihiro Suda <[email protected]>

Author: AkihiroSuda

pkg/qemu/qemu.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
+	"io/fs"
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -264,6 +265,16 @@ func Cmdline(cfg Config) (string, []string, error) {
 			if _, err := os.Stat(vdeSock); err != nil {
 				return "", nil, fmt.Errorf("cannot use VNL %q: %w", vde.VNL, err)
 			}
+			// vdeSock is a directory, unless vde.SwitchPort == 65535 (PTP)
+			actualSocket := filepath.Join(vdeSock, "ctl")
+			if vde.SwitchPort == 65535 { // PTP
+				actualSocket = vdeSock
+			}
+			if st, err := os.Stat(actualSocket); err != nil {
+				return "", nil, fmt.Errorf("cannot use VNL %q: failed to stat %q: %w", vde.VNL, actualSocket, err)
+			} else if st.Mode()&fs.ModeSocket == 0 {
+				return "", nil, fmt.Errorf("cannot use VNL %q: %q is not a socket: %w", vde.VNL, actualSocket, err)
+			}
 		}
 		args = append(args, "-netdev", fmt.Sprintf("vde,id=net%d,sock=%s", i+1, vdeSock))
 		args = append(args, "-device", fmt.Sprintf("virtio-net-pci,netdev=net%d,mac=%s", i+1, vde.MACAddress))