shellcheck: SC2086: Double quote to prevent globbing and word splitting.

Signed-off-by: Akihiro Suda <[email protected]>

Author: AkihiroSuda

.github/workflows/test.yml

@@ -32,11 +32,8 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y shellcheck
-      - name: Run shellcheck (ignore SC2086)
-        # TODO: do not ignore SC2086
-        # SC2086: "Double quote to prevent globbing and word splitting."
-        # https://github.com/koalaman/shellcheck/wiki/SC2086
-        run: find . -name '*.sh' | xargs shellcheck -e SC2086
+      - name: Run shellcheck
+        run: find . -name '*.sh' | xargs shellcheck
 
   shfmt:
     runs-on: ubuntu-20.04

pkg/cidata/cidata.TEMPLATE.d/boot/05-persistent-data-volume.sh

@@ -23,29 +23,29 @@ if [ "$(awk '$2 == "/" {print $3}' /proc/mounts)" == "tmpfs" ]; then
 			# Looking for a disk that is not mounted or partitioned
 			# shellcheck disable=SC2013
 			for PART in $(awk '/^\/dev\// {gsub("/dev/", ""); print $1}' /proc/mounts); do
-				if [ "${DISK}" == "${PART}" ] || [ -e /sys/block/${DISK}/${PART} ]; then
+				if [ "${DISK}" == "${PART}" ] || [ -e /sys/block/"${DISK}"/"${PART}" ]; then
 					IN_USE=true
 					break
 				fi
 			done
 			if [ "${IN_USE}" == "false" ]; then
-				echo 'type=83' | sfdisk --label dos /dev/${DISK}
-				PART=$(lsblk --list /dev/${DISK} --noheadings --output name,type | awk '$2 == "part" {print $1}')
-				mkfs.ext4 -L data-volume /dev/${PART}
+				echo 'type=83' | sfdisk --label dos /dev/"${DISK}"
+				PART=$(lsblk --list /dev/"${DISK}" --noheadings --output name,type | awk '$2 == "part" {print $1}')
+				mkfs.ext4 -L data-volume /dev/"${PART}"
 				mount -t ext4 /dev/disk/by-label/data-volume /mnt/data
 				for DIR in ${DATADIRS}; do
-					DEST="/mnt/data$(dirname ${DIR})"
-					mkdir -p ${DIR} ${DEST}
-					mv ${DIR} ${DEST}
+					DEST="/mnt/data$(dirname "${DIR}")"
+					mkdir -p "${DIR}" "${DEST}"
+					mv "${DIR}" "${DEST}"
 				done
 				break
 			fi
 		done
 	fi
 	for DIR in ${DATADIRS}; do
-		if [ -d /mnt/data${DIR} ]; then
-			[ -e ${DIR} ] && rm -rf ${DIR}
-			ln -s /mnt/data${DIR} ${DIR}
+		if [ -d /mnt/data"${DIR}" ]; then
+			[ -e "${DIR}" ] && rm -rf "${DIR}"
+			ln -s /mnt/data"${DIR}" "${DIR}"
 		fi
 	done
 fi

pkg/cidata/cidata.TEMPLATE.d/boot/25-guestagent-base.sh

@@ -5,7 +5,7 @@ set -eux
 # NOTE: Busybox sh does not support `for ((i=0;i<$N;i++))` form
 for f in $(seq 0 $((LIMA_CIDATA_MOUNTS - 1))); do
 	mountpointvar="LIMA_CIDATA_MOUNTS_${f}_MOUNTPOINT"
-	mountpoint="$(eval echo \$$mountpointvar)"
+	mountpoint="$(eval echo \$"$mountpointvar")"
 	mkdir -p "${mountpoint}"
 	chown "${LIMA_CIDATA_USER}" "${mountpoint}"
 done
@@ -16,9 +16,9 @@ install -m 755 "${LIMA_CIDATA_MNT}"/lima-guestagent /usr/local/bin/lima-guestage
 # Launch the guestagent service
 if [ -f /etc/alpine-release ]; then
 	# Create directory for the lima-guestagent socket (normally done by systemd)
-	mkdir -p /run/user/${LIMA_CIDATA_UID}
-	chown "${LIMA_CIDATA_USER}" /run/user/${LIMA_CIDATA_UID}
-	chmod 700 /run/user/${LIMA_CIDATA_UID}
+	mkdir -p /run/user/"${LIMA_CIDATA_UID}"
+	chown "${LIMA_CIDATA_USER}" /run/user/"${LIMA_CIDATA_UID}"
+	chmod 700 /run/user/"${LIMA_CIDATA_UID}"
 	# Install the openrc lima-guestagent service script
 	cat >/etc/init.d/lima-guestagent <<'EOF'
 #!/sbin/openrc-run