pkg/sshutil: Does // lgtm[go/insecure-hostkeycallback] works?

Signed-off-by: Norio Nomura <[email protected]>

Author: norio-nomura

pkg/sshutil/sshutil.go

@@ -536,7 +536,7 @@ func detectAESAcceleration() bool {
 // The dialContext function is used to create a connection to the SSH server.
 // The addr, user, privateKeyPath parameter is used for ssh.ClientConn creation.
 // The timeoutSeconds parameter specifies the maximum number of seconds to wait.
-func WaitSSHReady(ctx context.Context, dialContext func(context.Context) (net.Conn, error), addr, user, instanceName string, timeoutSeconds int) error {
+func WaitSSHReady(ctx context.Context, dialContext func(context.Context) (net.Conn, error), addr, user, _ string, timeoutSeconds int) error {
 	ctx, cancel := context.WithTimeout(ctx, time.Duration(timeoutSeconds)*time.Second)
 	defer cancel()
 
@@ -545,16 +545,11 @@ func WaitSSHReady(ctx context.Context, dialContext func(context.Context) (net.Co
 	if err != nil {
 		return err
 	}
-	// Prepare HostKeyCallback
-	hostKeyChecker, err := HostKeyCheckerWithKeysInKnownHosts(instanceName)
-	if err != nil {
-		return err
-	}
 	// Prepare ssh client config
 	sshConfig := &ssh.ClientConfig{
 		User:            user,
 		Auth:            []ssh.AuthMethod{ssh.PublicKeys(signer)},
-		HostKeyCallback: hostKeyChecker,
+		HostKeyCallback: ssh.InsecureIgnoreHostKey(), // lgtm[go/insecure-hostkeycallback]
 		Timeout:         10 * time.Second,
 	}
 	// Wait until the SSH server is available.
@@ -691,23 +686,17 @@ func GenerateSSHHostKeys(instDir, hostname string) (map[string]string, error) {
 }
 
 // ExecuteScriptViaInProcessClient executes the given script on the remote host via in-process SSH client.
-func ExecuteScriptViaInProcessClient(host string, port int, user, instanceName, script, scriptName string) (stdout, stderr string, err error) {
+func ExecuteScriptViaInProcessClient(host string, port int, user, _, script, scriptName string) (stdout, stderr string, err error) {
 	// Prepare signer
 	signer, err := UserPrivateKey()
 	if err != nil {
 		return "", "", err
 	}
-	// Prepare HostKeyCallback
-	hostKeyChecker, err := HostKeyCheckerWithKeysInKnownHosts(instanceName)
-	if err != nil {
-		return "", "", err
-	}
-
 	// Prepare ssh client config
 	sshConfig := &ssh.ClientConfig{
 		User:            user,
 		Auth:            []ssh.AuthMethod{ssh.PublicKeys(signer)},
-		HostKeyCallback: hostKeyChecker,
+		HostKeyCallback: ssh.InsecureIgnoreHostKey(), // lgtm[go/insecure-hostkeycallback]
 		Timeout:         10 * time.Second,
 	}