Skip to content

limactl disk should not depend on qemu-img for raw disks #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AkihiroSuda opened this issue Nov 6, 2024 · 0 comments · Fixed by #3180
Closed

limactl disk should not depend on qemu-img for raw disks #2853

AkihiroSuda opened this issue Nov 6, 2024 · 0 comments · Fixed by #3180
Labels
component/vz enhancement New feature or request

Comments

@AkihiroSuda
Copy link
Member

No description provided.

@AkihiroSuda AkihiroSuda added enhancement New feature or request component/vz labels Nov 6, 2024
nirs added a commit to nirs/lima that referenced this issue Jan 30, 2025
Fix `limactl disk create` and `limactl disk resize` to use nativeimgutil
for creating and resizing disks using raw format.

There are special cases (using direct I/O on certain file systems) when
creating a raw image should be done with qemu-img, but these are not
relevant to lima on macOS.

With this change we have no dependency on qemu when using VZ instance.

This change does not fix the issue of default "qcow2" disk format.
Users must specify the disk format when creating additional disks for VZ
instance:

    limactl disk create --format raw

Unfinished:
- Needs tests nativeimgutil and the disk command

Fixes: lima-vm#2853
Signed-off-by: Nir Soffer <[email protected]>
nirs added a commit to nirs/lima that referenced this issue Jan 30, 2025
Fix `limactl disk create` and `limactl disk resize` to use nativeimgutil
for creating and resizing disks using raw format.

There are special cases (using direct I/O on certain file systems) when
creating a raw image should be done with qemu-img, but these are not
relevant to lima on macOS.

With this change we have no dependency on qemu when using VZ instance.

This change does not fix the issue of default "qcow2" disk format.
Users must specify the disk format when creating additional disks for VZ
instance:

    limactl disk create --format raw

Unfinished:
- Needs tests nativeimgutil and the disk command

Fixes: lima-vm#2853
Signed-off-by: Nir Soffer <[email protected]>
nirs added a commit to nirs/lima that referenced this issue Jan 30, 2025
Fix `limactl disk create` and `limactl disk resize` to use nativeimgutil
for creating and resizing disks using raw format.

There are special cases (using direct I/O on certain file systems) when
creating a raw image should be done with qemu-img, but these are not
relevant to lima on macOS.

With this change we have no dependency on qemu when using VZ instance.

This change does not fix the issue of default "qcow2" disk format.
Users must specify the disk format when creating additional disks for VZ
instance:

    limactl disk create --format raw

Unfinished:
- Needs tests for nativeimgutil and disk command

Fixes: lima-vm#2853
Signed-off-by: Nir Soffer <[email protected]>
nirs added a commit to nirs/lima that referenced this issue Jan 30, 2025
Fix `limactl disk create` and `limactl disk resize` to use nativeimgutil
for creating and resizing disks using raw format.

There are special cases (using direct I/O on certain file systems) when
creating a raw image should be done with qemu-img, but these are not
relevant to lima on macOS.

With this change we have no dependency on qemu when using VZ instance.

This change does not fix the issue of default "qcow2" disk format.
Users must specify the disk format when creating additional disks for VZ
instance:

    limactl disk create --format raw

Unfinished:
- Needs tests for nativeimgutil and disk command

Fixes: lima-vm#2853
Signed-off-by: Nir Soffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/vz enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant