Skip to content

Commit 6690425

Browse files
committed
Fix test failures
1 parent ad0ab4f commit 6690425

File tree

2 files changed

+19
-15
lines changed

2 files changed

+19
-15
lines changed

core/src/test/java/com/linecorp/armeria/common/logging/JsonLogFormatterTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import org.junit.jupiter.params.ParameterizedTest;
2626
import org.junit.jupiter.params.provider.CsvSource;
2727

28+
import com.fasterxml.jackson.databind.JsonNode;
29+
2830
import com.linecorp.armeria.common.HttpHeaderNames;
2931
import com.linecorp.armeria.common.HttpMethod;
3032
import com.linecorp.armeria.common.HttpRequest;
@@ -160,13 +162,14 @@ void maskResponseHeaders() {
160162
@Test
161163
void maskRequestHeadersWithDuplicateHeaderName() {
162164
final HeaderMaskingFunction maskingFunction = (name, value) -> "****armeria****";
165+
final HeadersSanitizer<JsonNode> headersSanitizer =
166+
HeadersSanitizer.builderForJson()
167+
.sensitiveHeaders("accept-encoding")
168+
.sensitiveHeaders("content-type")
169+
.maskingFunction(maskingFunction)
170+
.build();
163171
final LogFormatter logFormatter = LogFormatter.builderForJson()
164-
.requestHeadersSanitizer(
165-
HeadersSanitizer.builderForJson()
166-
.sensitiveHeaders("accept-encoding")
167-
.sensitiveHeaders("content-type")
168-
.maskingFunction(maskingFunction)
169-
.build())
172+
.requestHeadersSanitizer(headersSanitizer)
170173
.build();
171174
final HttpRequest req = HttpRequest.of(RequestHeaders.of(HttpMethod.GET, "/hello",
172175
"Accept-Encoding", "gzip",

core/src/test/java/com/linecorp/armeria/common/logging/TextLogFormatterTest.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,14 @@ void maskResponseHeaders() {
184184
@Test
185185
void maskRequestHeadersWithDuplicateHeaderName() {
186186
final HeaderMaskingFunction maskingFunction = (name, value) -> "****armeria****";
187+
final HeadersSanitizer<String> headersSanitizer =
188+
HeadersSanitizer.builderForText()
189+
.sensitiveHeaders("accept-encoding")
190+
.sensitiveHeaders("content-type")
191+
.maskingFunction(maskingFunction)
192+
.build();
187193
final LogFormatter logFormatter = LogFormatter.builderForText()
188-
.requestHeadersSanitizer(
189-
HeadersSanitizer.builderForText()
190-
.sensitiveHeaders("accept-encoding")
191-
.sensitiveHeaders("content-type")
192-
.maskingFunction(maskingFunction)
193-
.build())
194+
.requestHeadersSanitizer(headersSanitizer)
194195
.build();
195196
final HttpRequest req = HttpRequest.of(RequestHeaders.of(HttpMethod.GET, "/hello",
196197
"Accept-Encoding", "gzip",
@@ -226,11 +227,11 @@ void removeSensitiveHeaders() {
226227
log.endResponse();
227228

228229
final String responseLog = logFormatter.formatResponse(log);
229-
final Matcher matcher1 = Pattern.compile("\"set-cookie\"=\"(.*?)\"").matcher(responseLog);
230+
final Matcher matcher1 = Pattern.compile("set-cookie=(.*?)[,\\]]").matcher(responseLog);
230231
assertThat(matcher1.find()).isFalse();
231-
final Matcher matcher2 = Pattern.compile("\"multiple-header\"=\"(.*?)\"").matcher(responseLog);
232+
final Matcher matcher2 = Pattern.compile("multiple-header=(.*?)[,\\]]").matcher(responseLog);
232233
assertThat(matcher2.find()).isFalse();
233-
final Matcher matcher3 = Pattern.compile("\"cache-control\"=\"(.*?)\"").matcher(responseLog);
234+
final Matcher matcher3 = Pattern.compile("cache-control=(.*?)[,\\]]").matcher(responseLog);
234235
assertThat(matcher3.find()).isTrue();
235236
assertThat(matcher3.group(1)).isEqualTo("no-cache");
236237
}

0 commit comments

Comments
 (0)