Commit d8f0879
authored
Fix flaky
Motivation:
`Subscriber.onComplete()` is invoked before `completionFuture` is
completed, so a happen-before relationship between
`byteStreamMessage.isOpen()` and `Subscriber.onComplete()` cannot be
guaranteed.
https://github.com/line/armeria/blob/0d94d0df85ba9b1184c79ffdd58d3e414b2f0c7d/core/src/main/java/com/linecorp/armeria/common/stream/InputStreamStreamMessage.java#L375-L376
Modifications:
- Use `.whenComplete().join()` to explicitly wait until
`InputStreamStreamMessage` completes.
Result:
Closes #6483InputStreamStreamMessageTest.emptyInputStream() (#6484)1 parent ba803e2 commit d8f0879
File tree
1 file changed
+2
-1
lines changed- core/src/test/java/com/linecorp/armeria/common/stream
1 file changed
+2
-1
lines changedLines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
406 | 406 | | |
407 | 407 | | |
408 | 408 | | |
| 409 | + | |
| 410 | + | |
409 | 411 | | |
410 | | - | |
411 | 412 | | |
412 | 413 | | |
413 | 414 | | |
| |||
0 commit comments