Skip to content

Commit 5c6fe0c

Browse files
author
Bryan Donovan
committed
Merge branch 'release/4.0.0'
2 parents d38176f + d0a90f4 commit 5c6fe0c

File tree

5 files changed

+36
-43
lines changed

5 files changed

+36
-43
lines changed

History.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
- 4.0.0
2+
- Upgrade to lru-cache 7.x (#193). - @orgads
3+
- This has a breaking change in memoryCache.dump().
4+
15
- 3.6.3 2022-05-20
26
- Remove import from the code in order to be able to bundle and minify the module (#191) - @ricardomozartlino
37

lib/stores/memory.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,13 @@ var memoryStore = function(args) {
3333
var ttl = args.ttl;
3434
var lruOpts = {
3535
max: args.max || 500,
36-
maxAge: (ttl || ttl === 0) ? ttl * 1000 : null,
36+
maxSize: args.maxSize,
37+
ttl: (ttl || ttl === 0) ? ttl * 1000 : null,
3738
dispose: args.dispose,
38-
length: args.length,
39-
stale: args.stale,
40-
updateAgeOnGet: args.updateAgeOnGet || false
39+
sizeCalculation: args.sizeCalculation || args.length,
40+
allowStale: args.allowStale || args.stale,
41+
updateAgeOnGet: args.updateAgeOnGet,
42+
updateAgeOnHas: args.updateAgeOnHas
4143
};
4244

4345
var lruCache = new Lru(lruOpts);
@@ -156,7 +158,7 @@ var memoryStore = function(args) {
156158
}
157159

158160
args.forEach(function(key) {
159-
lruCache.del(key);
161+
lruCache.delete(key);
160162
});
161163

162164
if (cb) {
@@ -167,7 +169,7 @@ var memoryStore = function(args) {
167169
};
168170

169171
self.reset = function(cb) {
170-
lruCache.reset();
172+
lruCache.clear();
171173
if (cb) {
172174
process.nextTick(cb.bind(null, null));
173175
} else if (self.usePromises) {
@@ -176,7 +178,7 @@ var memoryStore = function(args) {
176178
};
177179

178180
self.keys = function(cb) {
179-
var keys = lruCache.keys();
181+
var keys = [...lruCache.keys()];
180182
if (cb) {
181183
process.nextTick(cb.bind(null, null, keys));
182184
} else if (self.usePromises) {
@@ -190,7 +192,7 @@ var memoryStore = function(args) {
190192
* This method is not available in the caching modules.
191193
*/
192194
self.keyCount = function() {
193-
return lruCache.length;
195+
return lruCache.size;
194196
};
195197

196198
/**

package-lock.json

Lines changed: 6 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "cache-manager",
3-
"version": "3.6.3",
3+
"version": "4.0.0",
44
"description": "Cache module for Node.js",
55
"main": "index.js",
66
"files": [
@@ -27,7 +27,7 @@
2727
"dependencies": {
2828
"async": "3.2.3",
2929
"lodash.clonedeep": "^4.5.0",
30-
"lru-cache": "6.0.0"
30+
"lru-cache": "^7.10.1"
3131
},
3232
"devDependencies": {
3333
"coveralls": "3.1.0",

test/stores/memory.unit.js

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -314,10 +314,10 @@ describe("memory store", function() {
314314
memoryCache.set(key2, value2);
315315

316316
const data = memoryCache.dump();
317-
assert.equal(data[0].k, key2);
318-
assert.equal(data[0].v, value2);
319-
assert.equal(data[1].k, key1);
320-
assert.equal(data[1].v, value1);
317+
assert.equal(data[0][0], key1);
318+
assert.equal(data[0][1].value, value1);
319+
assert.equal(data[1][0], key2);
320+
assert.equal(data[1][1].value, value2);
321321
});
322322

323323
it("lets us dump data with callback", function() {
@@ -327,10 +327,10 @@ describe("memory store", function() {
327327

328328
memoryCache.dump((err, data) => {
329329
checkErr(err);
330-
assert.equal(data[0].k, key2);
331-
assert.equal(data[0].v, value2);
332-
assert.equal(data[1].k, key1);
333-
assert.equal(data[1].v, value1);
330+
assert.equal(data[0][0], key1);
331+
assert.equal(data[0][1].value, value1);
332+
assert.equal(data[1][0], key2);
333+
assert.equal(data[1][1].value, value2);
334334
});
335335
});
336336

@@ -340,10 +340,10 @@ describe("memory store", function() {
340340
memoryCache.set(key2, value2);
341341

342342
const data = await memoryCache.dump();
343-
assert.equal(data[0].k, key2);
344-
assert.equal(data[0].v, value2);
345-
assert.equal(data[1].k, key1);
346-
assert.equal(data[1].v, value1);
343+
assert.equal(data[0][0], key1);
344+
assert.equal(data[0][1].value, value1);
345+
assert.equal(data[1][0], key2);
346+
assert.equal(data[1][1].value, value2);
347347
});
348348
});
349349

@@ -361,14 +361,8 @@ describe("memory store", function() {
361361
key2 = support.random.string(20);
362362
value2 = support.random.string();
363363
data = [
364-
{
365-
k: key1,
366-
v: value1
367-
},
368-
{
369-
k: key2,
370-
v: value2
371-
}
364+
[key1, {value: value1}],
365+
[key2, {value: value2}]
372366
];
373367
});
374368

0 commit comments

Comments
 (0)