f2fs: compress: rename __cluster_may_compress

chaseyu · Jaegeuk Kim · commit 2ba2a38a9fca · 2021-05-24T10:22:19.000-07:00
This patch renames __cluster_may_compress() to cluster_has_invalid_data() for
better readability.

Signed-off-by: Chao Yu &lt;yuchao0@huawei.com&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
@@ -877,7 +877,7 @@ bool f2fs_cluster_can_merge_page(struct compress_ctx *cc, pgoff_t index)
 	return is_page_in_cluster(cc, index);
 }
 
-static bool __cluster_may_compress(struct compress_ctx *cc)
+static bool cluster_has_invalid_data(struct compress_ctx *cc)
 {
 	loff_t i_size = i_size_read(cc->inode);
 	unsigned nr_pages = DIV_ROUND_UP(i_size, PAGE_SIZE);
@@ -890,9 +890,9 @@ static bool __cluster_may_compress(struct compress_ctx *cc)
 
 		/* beyond EOF */
 		if (page->index >= nr_pages)
-			return false;
+			return true;
 	}
-	return true;
+	return false;
 }
 
 static int __f2fs_cluster_blocks(struct compress_ctx *cc, bool compr)
@@ -968,7 +968,7 @@ static bool cluster_may_compress(struct compress_ctx *cc)
 		return false;
 	if (unlikely(f2fs_cp_error(F2FS_I_SB(cc->inode))))
 		return false;
-	return __cluster_may_compress(cc);
+	return !cluster_has_invalid_data(cc);
 }
 
 static void set_cluster_writeback(struct compress_ctx *cc)

Original file line number	Diff line number	Diff line change
`@@ -877,7 +877,7 @@ bool f2fs_cluster_can_merge_page(struct compress_ctx *cc, pgoff_t index)`
`877`	`877`	`return is_page_in_cluster(cc, index);`
`878`	`878`	`}`
`879`	`879`
`880`		`-static bool __cluster_may_compress(struct compress_ctx *cc)`
	`880`	`+static bool cluster_has_invalid_data(struct compress_ctx *cc)`
`881`	`881`	`{`
`882`	`882`	`loff_t i_size = i_size_read(cc->inode);`
`883`	`883`	`unsigned nr_pages = DIV_ROUND_UP(i_size, PAGE_SIZE);`
`@@ -890,9 +890,9 @@ static bool __cluster_may_compress(struct compress_ctx *cc)`
`890`	`890`
`891`	`891`	`/* beyond EOF */`
`892`	`892`	`if (page->index >= nr_pages)`
`893`		`- return false;`
	`893`	`+ return true;`
`894`	`894`	`}`
`895`		`- return true;`
	`895`	`+ return false;`
`896`	`896`	`}`
`897`	`897`
`898`	`898`	`static int __f2fs_cluster_blocks(struct compress_ctx *cc, bool compr)`
`@@ -968,7 +968,7 @@ static bool cluster_may_compress(struct compress_ctx *cc)`
`968`	`968`	`return false;`
`969`	`969`	`if (unlikely(f2fs_cp_error(F2FS_I_SB(cc->inode))))`
`970`	`970`	`return false;`
`971`		`- return __cluster_may_compress(cc);`
	`971`	`+ return !cluster_has_invalid_data(cc);`
`972`	`972`	`}`
`973`	`973`
`974`	`974`	`static void set_cluster_writeback(struct compress_ctx *cc)`