Bug fix (#587)

Author: rakhiagr

dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java

@@ -736,11 +736,14 @@ <ASPECT_UNION extends RecordTemplate> URN createAspectsWithCallbacks(@Nonnull UR
       }
     }
 
-    // check if any the aspects are in test mode
-    boolean isTestModeFalseForAll = aspectCreateLambdas.stream().filter(aspectCreateLambda -> aspectCreateLambda.getIngestionParams().isTestMode()).collect(
-          Collectors.toList()).isEmpty();
-
-    int numRows = createNewAssetWithAspects(urn, aspectCreateLambdas, aspectValues, auditStamp, trackingContext, isTestModeFalseForAll);
+    // Check if any of the aspects are in test mode
+    // Assumption: Either all aspects will be in test mode OR all aspects will be in non-test mode.
+    // We check if the filtered list (aspects with test mode = true) is empty to determine if all are non-test mode.
+    boolean isTestModeFalseForAll = aspectCreateLambdas.stream()
+        .noneMatch(aspectCreateLambda -> aspectCreateLambda.getIngestionParams().isTestMode());
+
+    // Create the asset with aspects. Pass the negation since createNewAssetWithAspects expects isTestMode flag.
+    int numRows = createNewAssetWithAspects(urn, aspectCreateLambdas, aspectValues, auditStamp, trackingContext, !isTestModeFalseForAll);
     for (RecordTemplate aspectValue : aspectValues) {
       // For each aspect, we need to trigger emit MAE
       // In new asset creation, old value is null