Skip to content

Commit 388d2af

Browse files
committed
[dvc] Config flag for subscribing on disk partitions automatically. Updated with integration test and unit test.
1 parent f621cc7 commit 388d2af

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ private Function<String, Boolean> functionToCheckWhetherStorageEngineShouldBeKep
399399
};
400400
}
401401

402-
protected synchronized void bootstrap() {
402+
final synchronized void bootstrap() {
403403
List<AbstractStorageEngine> storageEngines =
404404
storageService.getStorageEngineRepository().getAllLocalStorageEngines();
405405
LOGGER.info("Starting bootstrap, storageEngines: {}", storageEngines);

clients/da-vinci-client/src/test/java/com/linkedin/davinci/DaVinciBackendTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,10 +267,10 @@ public Object answer(InvocationOnMock invocation) throws Throwable {
267267
when(mockCombinedProperties.getBoolean(anyString(), anyBoolean())).thenReturn(true);
268268
backend.bootstrap();
269269

270+
// DA_VINCI_SUBSCRIBE_ON_DISK_PARTITIONS_AUTOMATICALLY == true
270271
subscription = mockStoreBackend.getSubscription();
271272
assertTrue(subscription.contains(0));
272273
assertTrue(subscription.contains(1));
273274
assertTrue(subscription.contains(2));
274-
275275
}
276276
}

0 commit comments

Comments
 (0)