Skip to content

Commit a4209a9

Browse files
committed
Added ParentControllerRegionState properties to tests
1 parent 8e0858b commit a4209a9

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/controller/server/TestAdminSparkServer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import com.linkedin.venice.LastSucceedExecutionIdResponse;
88
import com.linkedin.venice.common.VeniceSystemStoreType;
99
import com.linkedin.venice.controller.Admin;
10+
import com.linkedin.venice.controller.ParentControllerRegionState;
1011
import com.linkedin.venice.controller.VeniceHelixAdmin;
1112
import com.linkedin.venice.controllerapi.AdminCommandExecution;
1213
import com.linkedin.venice.controllerapi.ControllerApiConstants;
@@ -102,6 +103,7 @@ public void setUp() {
102103
extraProperties
103104
.put(ConfigKeys.CONTROLLER_DEFAULT_MAX_RECORD_SIZE_BYTES, Integer.toString(TEST_MAX_RECORD_SIZE_BYTES));
104105
extraProperties.put(ConfigKeys.MIN_NUMBER_OF_UNUSED_KAFKA_TOPICS_TO_PRESERVE, Integer.toString(1));
106+
extraProperties.put(ConfigKeys.CONTROLLER_PARENT_REGION_STATE, ParentControllerRegionState.ACTIVE.name());
105107
super.setUp(false, Optional.empty(), extraProperties);
106108
}
107109

internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/controller/server/TestAdminSparkWithMocks.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import static org.mockito.Mockito.doReturn;
77
import static org.mockito.Mockito.eq;
88

9+
import com.linkedin.venice.controller.ParentControllerRegionState;
910
import com.linkedin.venice.controller.VeniceHelixAdmin;
1011
import com.linkedin.venice.controllerapi.ControllerApiConstants;
1112
import com.linkedin.venice.controllerapi.ControllerRoute;
@@ -205,6 +206,7 @@ public void testAAIncrementalPushRTSourceRegion(boolean sourceGridFabricPresent,
205206
mockStore.setIncrementalPushEnabled(true);
206207
doReturn(mockStore).when(admin).getStore(anyString(), anyString());
207208
doReturn(true).when(admin).isParent();
209+
doReturn(ParentControllerRegionState.ACTIVE).when(admin).getParentControllerRegionState();
208210
doReturn(true).when(admin).isLeaderControllerFor(anyString());
209211
doReturn(1).when(admin).getReplicationFactor(anyString(), anyString());
210212
doReturn(1).when(admin).calculateNumberOfPartitions(anyString(), anyString());
@@ -330,6 +332,7 @@ public void testSamzaReplicationPolicyMode(boolean samzaPolicy, boolean storePol
330332
doReturn("kafka-bootstrap").when(admin).getKafkaBootstrapServers(anyBoolean());
331333
doReturn("store_rt").when(admin).getRealTimeTopic(anyString(), anyString());
332334
doReturn(samzaPolicy).when(admin).isParent();
335+
doReturn(ParentControllerRegionState.ACTIVE).when(admin).getParentControllerRegionState();
333336
doReturn(aaEnabled).when(admin).isActiveActiveReplicationEnabledInAllRegion(anyString(), anyString(), eq(true));
334337
mockStore.setActiveActiveReplicationEnabled(aaEnabled);
335338

internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/controller/server/TestBackupControllerResponse.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
import static com.linkedin.venice.controllerapi.ControllerRoute.JOB;
55
import static com.linkedin.venice.controllerapi.ControllerRoute.REQUEST_TOPIC;
66

7+
import com.linkedin.venice.ConfigKeys;
78
import com.linkedin.venice.HttpConstants;
9+
import com.linkedin.venice.controller.ParentControllerRegionState;
810
import com.linkedin.venice.controllerapi.ControllerTransport;
911
import com.linkedin.venice.controllerapi.QueryParams;
1012
import com.linkedin.venice.controllerapi.VersionCreationResponse;
@@ -17,6 +19,7 @@
1719
import com.linkedin.venice.integration.utils.VeniceControllerWrapper;
1820
import com.linkedin.venice.integration.utils.ZkServerWrapper;
1921
import java.util.Optional;
22+
import java.util.Properties;
2023
import java.util.concurrent.ExecutionException;
2124
import java.util.concurrent.TimeoutException;
2225
import org.testng.Assert;
@@ -27,6 +30,8 @@ public class TestBackupControllerResponse {
2730
@Test
2831
public void backupControllerThrows421() throws Exception {
2932
String clusterName = "backupControllerThrows421";
33+
Properties extraProperties = new Properties();
34+
extraProperties.put(ConfigKeys.CONTROLLER_PARENT_REGION_STATE, ParentControllerRegionState.ACTIVE.name());
3035
try (ZkServerWrapper zkServer = ServiceFactory.getZkServer();
3136
PubSubBrokerWrapper pubSubBrokerWrapper = ServiceFactory.getPubSubBroker(
3237
new PubSubBrokerConfigs.Builder().setZkWrapper(zkServer)
@@ -36,10 +41,12 @@ public void backupControllerThrows421() throws Exception {
3641
VeniceControllerWrapper controller1 = ServiceFactory.getVeniceController(
3742
new VeniceControllerCreateOptions.Builder(clusterName, zkServer, pubSubBrokerWrapper)
3843
.regionName(VeniceClusterWrapperConstants.STANDALONE_REGION_NAME)
44+
.extraProperties(extraProperties)
3945
.build());
4046
VeniceControllerWrapper controller2 = ServiceFactory.getVeniceController(
4147
new VeniceControllerCreateOptions.Builder(clusterName, zkServer, pubSubBrokerWrapper)
4248
.regionName(VeniceClusterWrapperConstants.STANDALONE_REGION_NAME)
49+
.extraProperties(extraProperties)
4350
.build())) {
4451
// TODO: Eliminate sleep to make test reliable
4552
Thread.sleep(2000);

0 commit comments

Comments
 (0)