Skip to content

Commit c449df8

Browse files
committed
fix stale 'uses reflection' comments in test Javadoc
Updated two test method Javadoc comments that still referenced reflection-based RetryManager replacement to reference the setSingleKeyLongTailRetryManager(...) test hook instead.
1 parent d41c63f commit c449df8

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

clients/venice-client/src/test/java/com/linkedin/venice/fastclient/RetriableAvroGenericStoreClientTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -863,8 +863,9 @@ public void testGetWithTriggeringLongTailRetryAndBothFailsV2(RequestType request
863863
* This is the exact scenario observed in the mirror heap dump: instance returns 500 on heartbeat,
864864
* many requests time out exhausting the retry budget, subsequent requests hang forever.
865865
*
866-
* We use reflection to replace the internal RetryManager with a mock that always denies retries,
867-
* ensuring deterministic reproduction regardless of timing.
866+
* This test uses the {@code setSingleKeyLongTailRetryManager(...)} test hook to install a
867+
* {@link RetryManager} that always denies retries, ensuring deterministic reproduction
868+
* of this scenario regardless of timing.
868869
*/
869870
@Test(timeOut = TEST_TIMEOUT)
870871
public void testFinalFutureHangsWhenRetryBudgetExhaustedAndOriginalFails() throws Exception {
@@ -992,7 +993,7 @@ protected CompletableFuture get(GetRequestContext requestContext, Object key) th
992993
* BUG REPRODUCTION (variant with shorter threshold): Same as above but uses a 20ms threshold
993994
* to clearly demonstrate the timing: long-tail fires at 20ms (budget denied → does nothing),
994995
* original fails at 200ms (timeoutFuture.isDone()=true → error retry skipped).
995-
* Uses reflection to mock the RetryManager for deterministic reproduction.
996+
* Uses {@code setSingleKeyLongTailRetryManager(...)} to inject a mock RetryManager for deterministic reproduction.
996997
*/
997998
@Test(timeOut = TEST_TIMEOUT)
998999
public void testFinalFutureHangsWhenLongTailFiresBeforeOriginalFailsAndBudgetExhausted() throws Exception {

0 commit comments

Comments
 (0)