Skip to content

Commit 15c1789

Browse files
committed
address PR review comments on improving test_materialize_nonscalar_slot_usage()
1 parent 672c80d commit 15c1789

File tree

3 files changed

+5
-55
lines changed

3 files changed

+5
-55
lines changed

linkml_runtime/utils/schemaview.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1372,7 +1372,11 @@ def induced_slot(self, slot_name: SLOT_NAME, class_name: CLASS_NAME = None, impo
13721372
else:
13731373
# can rewrite below as:
13741374
# 1. if v2:
1375-
# 2. if v2 is not None and ((isinstance(v2, (dict, list)) and v2) or (isinstance(v2, JsonObj) and as_dict(v2)))
1375+
# 2. if v2 is not None and
1376+
# (
1377+
# (isinstance(v2, (dict, list)) and v2) or
1378+
# (isinstance(v2, JsonObj) and as_dict(v2))
1379+
# )
13761380
if not is_empty(v2):
13771381
v = v2
13781382
logging.debug(f'{v} takes precedence over {v2} for {induced_slot.name}.{metaslot_name}')

tests/test_issues/test_issue_2224.py

Lines changed: 0 additions & 51 deletions
This file was deleted.

tests/test_issues/input/linkml_issue_2224.yaml renamed to tests/test_utils/input/DJ_controller_schema.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@ classes:
1717
- value: 144.0
1818
- value: 126.8
1919
- value: 102.6
20-
annotations:
21-
expected_value: a number between 0 and 300
22-
preferred_unit: BPM
2320
slots:
2421
jog_wheels:
2522
description: The number of jog wheels on the DJ controller

0 commit comments

Comments
 (0)