Skip to content

Commit 7c311d9

Browse files
authored
Merge pull request #303 from linkml/linkml-issue-1942
Fixed CURIE validation to be conformant.
2 parents 5fa3115 + 27b9158 commit 7c311d9

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

linkml_runtime/utils/metamodelcore.py

-2
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,6 @@ def ns_ln(cls, v: str) -> Optional[Tuple[str, str]]:
177177
if not NCName.is_valid(prefix):
178178
return None
179179
reference = curie_split[1]
180-
if not cls.term_name.match(reference):
181-
return None
182180
return prefix, reference
183181

184182
@classmethod

tests/test_utils/test_metamodelcore.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,11 @@ def test_curie(self):
6666
self.assertTrue(Curie.is_valid(':type'))
6767
self.assertTrue(Curie.is_valid('WIKIDATA_PROPERTY:P854'))
6868
self.assertTrue(Curie.is_valid('WIKIDATA.PROPERTY:P854'))
69+
self.assertTrue(Curie.is_valid('CL:0000001'))
6970
with self.assertRaises(ValueError):
7071
Curie("1df:type")
7172
self.assertFalse(Curie.is_valid('1df:type'))
72-
with self.assertRaises(ValueError):
73-
Curie("rdf:17")
74-
self.assertFalse(Curie.is_valid('rdf:17'))
73+
self.assertTrue(Curie.is_valid('rdf:17'))
7574
nsm = Namespaces(Graph())
7675
self.assertEqual(RDF.type, Curie("rdf:type").as_uri(nsm))
7776
self.assertIsNone(Curie("ex:foo").as_uri(nsm))

0 commit comments

Comments
 (0)