Skip to content

Failing linkml-runtime action test_upstream.yaml (poetry2-related?) #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dalito opened this issue Jan 31, 2025 · 4 comments · Fixed by linkml/linkml-runtime#387
Closed

Failing linkml-runtime action test_upstream.yaml (poetry2-related?) #2520

dalito opened this issue Jan 31, 2025 · 4 comments · Fixed by linkml/linkml-runtime#387
Labels
bug Something that should work but isn't, with an example and a test case. community-generated linkml-runtime

Comments

@dalito
Copy link
Member

dalito commented Jan 31, 2025 •
edited
Loading

Describe the bug

With Poetry 2 the linkml-runtime action test_upstream.yaml fails.

(I first thought) the problem is the dependency specification in linkml´s pyproject.toml which constrains Python to ^3.8.1 because I though it means >3.8.1 and <3.9. But it is not the case (see @sneakers-the-rat comment).

Here is the recent failure log:

Updating dependencies
Resolving dependencies...

The current project's supported Python range (>=3.8.1,<4.0.0) is not compatible with some of the required packages Python requirement:
  - linkml-runtime requires Python ^3.9, so it will not be satisfied for Python >=3.8.1,<3.9

Because linkml depends on linkml-runtime (0.0.0) @ file:///home/runner/work/linkml-runtime/linkml-runtime/linkml-runtime which requires Python ^3.9, version solving failed.

  * Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties

    For linkml-runtime, a possible solution would be to set the `python` property to ">=3.9,<4.0.0"

    https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies,
    https://python-poetry.org/docs/dependency-specification/#using-environment-markers

Error: Process completed with exit code 1.

Version of LinkML you are using
1.8.6
@dalito dalito added the bug Something that should work but isn't, with an example and a test case. label Jan 31, 2025
This was referenced Jan 31, 2025
Closed
Closed
@sneakers-the-rat
Copy link
Collaborator

(^3.8.1 is >=3.8.1,<4.0.0, i think this error comes from linkml-runtime being bumped to minimum 3.9 while linkml is still minimum 3.8.1 <3 )

@dalito
Copy link
Member Author

dalito commented Jan 31, 2025 •
edited
Loading

Oh. You are right regarding the ^meaning; I mixed it up with ~3.8.1.

I updated the issue report and title and closed the PR.

@dalito dalito changed the title Pin of Python version too narrow in pyproject.toml Failing linkml-runtime action test_upstream.yaml (caused by Poetry 2?) Jan 31, 2025
@dalito dalito changed the title Failing linkml-runtime action test_upstream.yaml (caused by Poetry 2?) Failing linkml-runtime action test_upstream.yaml (poetry2-related?) Jan 31, 2025
@sneakers-the-rat
Copy link
Collaborator

Totally understandable, it's confusing.

We just gotta merge these bad boys
#2358
linkml/linkml-runtime#345

@dalito
Copy link
Member Author

dalito commented Feb 1, 2025 •
edited
Loading

It works now with linkml/linkml-runtime#364 (except on python 3.8). I also simplified the action a bit by using poetry sync.

The main problem was that poetry-dynamic-versioning did not work when auto-installed. But if the plugin is injected into pipx all works fine.

@dalito dalito mentioned this issue Apr 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that should work but isn't, with an example and a test case. community-generated linkml-runtime
Projects
None yet
Milestone
No milestone
3 participants
@nlharris @dalito @sneakers-the-rat