[fix] : set reason to none if nothing specified (#628)

* set reason to none if nothing specified so that condition upgrade doesn't fail

* fix empty reason for other controllers as well

Author: rahulait

api/v1alpha2/linodecluster_types.go

@@ -103,6 +103,11 @@ type LinodeCluster struct {
 }
 
 func (lc *LinodeCluster) GetConditions() []metav1.Condition {
+	for i := range lc.Status.Conditions {
+		if lc.Status.Conditions[i].Reason == "" {
+			lc.Status.Conditions[i].Reason = DefaultConditionReason
+		}
+	}
 	return lc.Status.Conditions
 }
 

api/v1alpha2/linodefirewall_types.go

@@ -137,6 +137,11 @@ type LinodeFirewall struct {
 }
 
 func (lfw *LinodeFirewall) GetConditions() []metav1.Condition {
+	for i := range lfw.Status.Conditions {
+		if lfw.Status.Conditions[i].Reason == "" {
+			lfw.Status.Conditions[i].Reason = DefaultConditionReason
+		}
+	}
 	return lfw.Status.Conditions
 }
 

api/v1alpha2/linodemachine_types.go

@@ -27,7 +27,8 @@ import (
 const (
 	// MachineFinalizer allows ReconcileLinodeMachine to clean up Linode resources associated
 	// with LinodeMachine before removing it from the apiserver.
-	MachineFinalizer = "linodemachine.infrastructure.cluster.x-k8s.io"
+	MachineFinalizer       = "linodemachine.infrastructure.cluster.x-k8s.io"
+	DefaultConditionReason = "None"
 )
 
 // LinodeMachineSpec defines the desired state of LinodeMachine
@@ -237,6 +238,11 @@ type LinodeMachine struct {
 }
 
 func (lm *LinodeMachine) GetConditions() []metav1.Condition {
+	for i := range lm.Status.Conditions {
+		if lm.Status.Conditions[i].Reason == "" {
+			lm.Status.Conditions[i].Reason = DefaultConditionReason
+		}
+	}
 	return lm.Status.Conditions
 }
 

api/v1alpha2/linodeobjectstoragebucket_types.go

@@ -105,6 +105,11 @@ type LinodeObjectStorageBucket struct {
 }
 
 func (losb *LinodeObjectStorageBucket) GetConditions() []metav1.Condition {
+	for i := range losb.Status.Conditions {
+		if losb.Status.Conditions[i].Reason == "" {
+			losb.Status.Conditions[i].Reason = DefaultConditionReason
+		}
+	}
 	return losb.Status.Conditions
 }
 

api/v1alpha2/linodeobjectstoragekey_types.go

@@ -133,6 +133,11 @@ type LinodeObjectStorageKey struct {
 }
 
 func (losk *LinodeObjectStorageKey) GetConditions() []metav1.Condition {
+	for i := range losk.Status.Conditions {
+		if losk.Status.Conditions[i].Reason == "" {
+			losk.Status.Conditions[i].Reason = DefaultConditionReason
+		}
+	}
 	return losk.Status.Conditions
 }
 

api/v1alpha2/linodeplacementgroup_types.go

@@ -118,6 +118,11 @@ type LinodePlacementGroup struct {
 }
 
 func (lpg *LinodePlacementGroup) GetConditions() []metav1.Condition {
+	for i := range lpg.Status.Conditions {
+		if lpg.Status.Conditions[i].Reason == "" {
+			lpg.Status.Conditions[i].Reason = DefaultConditionReason
+		}
+	}
 	return lpg.Status.Conditions
 }
 

api/v1alpha2/linodevpc_types.go

@@ -124,6 +124,11 @@ type LinodeVPC struct {
 }
 
 func (lv *LinodeVPC) GetConditions() []metav1.Condition {
+	for i := range lv.Status.Conditions {
+		if lv.Status.Conditions[i].Reason == "" {
+			lv.Status.Conditions[i].Reason = DefaultConditionReason
+		}
+	}
 	return lv.Status.Conditions
 }