Skip to content

Commit fbbba60

Browse files
committed
add test for nil nb
1 parent 0960775 commit fbbba60

File tree

1 file changed

+16
-3
lines changed

1 file changed

+16
-3
lines changed

controller/linodecluster_controller_test.go

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,23 +109,36 @@ var _ = Describe("cluster-lifecycle", Ordered, Label("cluster", "cluster-lifecyc
109109
}, nil)
110110
}),
111111
Path(
112-
Call("cluster is not created because there is no nb", func(ctx context.Context, m Mock) {
112+
Call("cluster is not created because there was an error creating nb", func(ctx context.Context, m Mock) {
113113
cScope.LinodeClient = m.NodeBalancerClient
114114
getNB := m.NodeBalancerClient.EXPECT().ListNodeBalancers(gomock.Any(), gomock.Any()).Return(nil, nil)
115115
m.NodeBalancerClient.EXPECT().CreateNodeBalancer(gomock.Any(), gomock.Any()).
116116
After(getNB).
117117
Return(nil, errors.New("create NB error"))
118118
}),
119-
Result("error", func(ctx context.Context, m Mock) {
119+
Result("create nb error", func(ctx context.Context, m Mock) {
120120
_, err := reconciler.reconcile(ctx, cScope, logr.Logger{})
121121
Expect(err.Error()).To(ContainSubstring("create NB error"))
122122
}),
123123
),
124+
Path(
125+
Call("cluster is not created because nb was nil", func(ctx context.Context, m Mock) {
126+
cScope.LinodeClient = m.NodeBalancerClient
127+
getNB := m.NodeBalancerClient.EXPECT().ListNodeBalancers(gomock.Any(), gomock.Any()).Return(nil, nil)
128+
m.NodeBalancerClient.EXPECT().CreateNodeBalancer(gomock.Any(), gomock.Any()).
129+
After(getNB).
130+
Return(nil, nil)
131+
}),
132+
Result("created nb is nil", func(ctx context.Context, m Mock) {
133+
_, err := reconciler.reconcile(ctx, cScope, logr.Logger{})
134+
Expect(err.Error()).To(ContainSubstring("nodeBalancer created was nil"))
135+
}),
136+
),
124137
Path(
125138
Call("cluster is not created because there is no capl cluster", func(ctx context.Context, m Mock) {
126139
cScope.LinodeClient = m.NodeBalancerClient
127140
}),
128-
Result("error", func(ctx context.Context, m Mock) {
141+
Result("no capl cluster error", func(ctx context.Context, m Mock) {
129142
reconciler.Client = k8sClient
130143
_, err := reconciler.Reconcile(ctx, reconcile.Request{
131144
NamespacedName: client.ObjectKeyFromObject(cScope.LinodeCluster),

0 commit comments

Comments
 (0)