try to get nodebalancers by IP before hostname

0xch4z · 0xch4z · commit 4bbf096614a1 · 2021-03-05T11:20:34.000-05:00
diff --git a/cloud/linode/loadbalancers.go b/cloud/linode/loadbalancers.go
@@ -124,12 +124,12 @@ func (l *loadbalancers) getLatestServiceLoadBalancerStatus(ctx context.Context,
 // most recent LoadBalancer status.
 func (l *loadbalancers) getNodeBalancerByStatus(ctx context.Context, service *v1.Service) (nb *linodego.NodeBalancer, err error) {
 	for _, ingress := range service.Status.LoadBalancer.Ingress {
-		if ingress.Hostname != "" {
-			return l.getNodeBalancerByHostname(ctx, service, ingress.Hostname)
-		}
 		if ingress.IP != "" {
 			return l.getNodeBalancerByIPv4(ctx, service, ingress.IP)
 		}
+		if ingress.Hostname != "" {
+			return l.getNodeBalancerByHostname(ctx, service, ingress.Hostname)
+		}
 	}
 	return nil, lbNotFoundError{serviceNn: getServiceNn(service)}
 }

Original file line number	Diff line number	Diff line change
`@@ -124,12 +124,12 @@ func (l *loadbalancers) getLatestServiceLoadBalancerStatus(ctx context.Context,`
`124`	`124`	`// most recent LoadBalancer status.`
`125`	`125`	`func (l loadbalancers) getNodeBalancerByStatus(ctx context.Context, service v1.Service) (nb *linodego.NodeBalancer, err error) {`
`126`	`126`	`for _, ingress := range service.Status.LoadBalancer.Ingress {`
`127`		`- if ingress.Hostname != "" {`
`128`		`- return l.getNodeBalancerByHostname(ctx, service, ingress.Hostname)`
`129`		`- }`
`130`	`127`	`if ingress.IP != "" {`
`131`	`128`	`return l.getNodeBalancerByIPv4(ctx, service, ingress.IP)`
`132`	`129`	`}`
	`130`	`+ if ingress.Hostname != "" {`
	`131`	`+ return l.getNodeBalancerByHostname(ctx, service, ingress.Hostname)`
	`132`	`+ }`
`133`	`133`	`}`
`134`	`134`	`return nil, lbNotFoundError{serviceNn: getServiceNn(service)}`
`135`	`135`	`}`