godoc: fix missing (Added in Go) "x.xx" for function with type parameters

For HTML documentation using godoc, since the introduction of type
parameters, the new API for function with type parameters has not been
rendered recently (no 1.XX displayed on the right).

This changes fix it by checking for "[" first in the function name
before "(".

Change-Id: I9421e095bbce7ffe5f871441160d6cc87cc3f299
Reviewed-on: https://go-review.googlesource.com/c/tools/+/639475
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Author: shuLhan

godoc/versions.go

@@ -189,7 +189,7 @@ func parseRow(s string) (vr versionedRow, ok bool) {
 	case strings.HasPrefix(rest, "func "):
 		vr.kind = "func"
 		rest = rest[len("func "):]
-		if i := strings.IndexByte(rest, '('); i != -1 {
+		if i := strings.IndexAny(rest, "[("); i != -1 {
 			vr.name = rest[:i]
 			return vr, true
 		}

godoc/versions_test.go

@@ -65,6 +65,27 @@ func TestParseVersionRow(t *testing.T) {
 				recv: "Encoding",
 			},
 		},
+		{
+			// Function with type parameters.
+			// Taken from "go/src/api/go1.21.txt".
+			row: "pkg cmp, func Compare[$0 Ordered]($0, $0) int #59488",
+			want: versionedRow{
+				pkg:  "cmp",
+				kind: "func",
+				name: "Compare",
+			},
+		},
+		{
+			// Function without type parameter but have "[" after
+			// "(" should have works as is.
+			// Taken from "go/src/api/go1.21.txt".
+			row: "pkg bytes, func ContainsFunc([]uint8, func(int32) bool) bool #54386",
+			want: versionedRow{
+				pkg:  "bytes",
+				kind: "func",
+				name: "ContainsFunc",
+			},
+		},
 	}
 
 	for i, tt := range tests {