Skip to content

Commit a797b47

Browse files
committed
ci: tox-lsr 3.4.0 - fix py27 tests; move other checks to py310
The latest version of virtualenv does not support creating python 2.7 virtualenvs. Change our CI tests to restrict the version of virtualenv<20.22.0 and tox<4.15 for py27 environments Move pylint, flake8, and black checks to the py310 environment which is currently supported by ansible-core 2.17 and its related checkers such as ansible-lint and ansible-test pylint now uses ansible-core 2.17 and restricts the version of pylint to 3.1.0 which is the version used by ansible-test 2.17 Remove `extends: default` for .yamllint.yml. The latest version of ansible-lint will automatically incorporate local yamllint settings unless there is an `extends:`. The above changes require some fixes to the role code. For more information, see linux-system-roles/tox-lsr#168 and linux-system-roles/tox-lsr#170 Signed-off-by: Rich Megginson <[email protected]>
1 parent f3e250c commit a797b47

File tree

5 files changed

+4
-5
lines changed

5 files changed

+4
-5
lines changed

.github/workflows/ansible-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
- name: Install tox, tox-lsr
3333
run: |
3434
set -euxo pipefail
35-
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.3.0"
35+
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.4.0"
3636
3737
- name: Convert role to collection format
3838
run: |

.github/workflows/ansible-managed-var-comment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Install tox, tox-lsr
3131
run: |
3232
set -euxo pipefail
33-
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.3.0"
33+
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.4.0"
3434
3535
- name: Run ansible-plugin-scan
3636
run: |

.github/workflows/ansible-plugin-scan.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Install tox, tox-lsr
3131
run: |
3232
set -euxo pipefail
33-
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.3.0"
33+
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.4.0"
3434
3535
- name: Run ansible-plugin-scan
3636
run: |

.github/workflows/ansible-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
- name: Install tox, tox-lsr
3434
run: |
3535
set -euxo pipefail
36-
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.3.0"
36+
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.4.0"
3737
3838
- name: Convert role to collection format
3939
run: |

.yamllint.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# SPDX-License-Identifier: MIT
22
---
3-
extends: default
43
ignore: |
54
/.tox/

0 commit comments

Comments
 (0)