Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken using node 12 #1

Open
No9 opened this issue Apr 5, 2020 · 2 comments
Open

Broken using node 12 #1

No9 opened this issue Apr 5, 2020 · 2 comments

Comments

@No9
Copy link

No9 commented Apr 5, 2020

I just tried running this against v12.6.1 and there are a number of issues.
@mmarchini I noticed on your repo you had started looking at n-api
https://github.com/mmarchini/node-usdt/tree/n-api.
Do you have a view on which way it should go?
i.e. Stick with NaN and or move to n-api?
Would appreciate getting your perspective on it :)

@mmarchini
Copy link
Collaborator

We should move to N-API. I haven't worked in this lib for a while though, but I guess it should be easy enough to migrate. What's your use case?

@No9
Copy link
Author

No9 commented Apr 6, 2020

Thanks for the pointer
I'm looking at diagnostic user journeys in a kubernetes environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants