Merge pull request #211 from madhuthorat/upstatdfail_fdclose

dang · web-flow · commit 925ee1ecf206 · 2020-06-11T09:39:08.000-04:00
In clnt_tli_ncreate() close FD in case client creation failed
diff --git a/src/clnt_generic.c b/src/clnt_generic.c
@@ -401,6 +401,9 @@ clnt_tli_ncreate(int fd, const struct netconfig *nconf,
 		goto err;
 	}
 
+	if (CLNT_FAILURE(cl))
+		goto err1;
+
 	if (flags & CLNT_CREATE_FLAG_CLOSE) {
 		/* We got a new FD; this makes it a local client */
 		cl->cl_flags |= CLNT_FLAG_LOCAL;

Original file line number	Diff line number	Diff line change
`@@ -401,6 +401,9 @@ clnt_tli_ncreate(int fd, const struct netconfig *nconf,`
`401`	`401`	`goto err;`
`402`	`402`	`}`
`403`	`403`
	`404`	`+ if (CLNT_FAILURE(cl))`
	`405`	`+ goto err1;`
	`406`	`+`
`404`	`407`	`if (flags & CLNT_CREATE_FLAG_CLOSE) {`
`405`	`408`	`/* We got a new FD; this makes it a local client */`
`406`	`409`	`cl->cl_flags \|= CLNT_FLAG_LOCAL;`