[BUG] Runtime update not supported

[anderspede]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Since the 1.41.0.8994-f2c27da23-ls239 release which adds support for running the container in read-only mode, the container is no longer able to self-update despite VERSION=latest being set and the container being in read-write mode.

It would appear that the check is faulty and in fact always blocks updating unless LSIO_READ_ONLY_FS and LSIO_NON_ROOT_USER are both defined, which I guess they shouldn't be unless the container is actually running in read-only mode.

The 1.41.0.8994-f2c27da23-ls239 release prints the following line instead of updating:

Runtime update not supported with read-only or non-root operation, skipping.

Downgrading the container to 1.41.0.8994-f2c27da23-ls238 fixes the issue:

Attempting to upgrade to: 1.41.1.9057-af5eaea7a
2024-10-14 18:25:41 URL:https://downloads.plex.tv/plex-media-server-new/1.41.1.9057-af5eaea7a/debian/plexmediaserver_1.41.1.9057-af5eaea7a_amd64.deb [81471786/81471786] -> "/tmp/plexmediaserver_1.41.1.9057-af5eaea7a_amd64.deb" [1]
...

Expected Behavior

When running the container in read-write mode, and VERSION=latest is set, and a plex-pass update is available, the container should self-update as normal.

Steps To Reproduce

1. Launch a container and claim it with a plex-pass account
2. Restart the container
3. Verify that it doesn't update but prints the error message instead

Environment

Fedora 40 with Docker CE

CPU architecture

x86-64

Docker creation

services:
  plex:
    image: lscr.io/linuxserver/plex:latest
    container_name: plex
    restart: unless-stopped
    network_mode: host
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=UTC
      - VERSION=latest
    devices:
      - /dev/dri:/dev/dri
    volumes:
      - /data/plex/config:/config
      - /data/media:/media

Container logs

[migrations] started
[migrations] no migrations found
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    1000
User GID:    1000
───────────────────────────────────────
Linuxserver.io version: 1.41.0.8994-f2c27da23-ls239
Build-date: 2024-10-14T08:14:47+00:00
───────────────────────────────────────

Setting permissions on /transcode
**** Server already claimed ****
**** adding /dev/dri/card1 to video group irc with id 39 ****
**** creating video group videom8ny with id 105 ****
**** adding /dev/dri/renderD128 to video group videom8ny with id 105 ****
Runtime update not supported with read-only or non-root operation, skipping.
[custom-init] No custom files found, skipping...
Starting Plex Media Server. . . (you can ignore the libusb_init error)
Connection to localhost (::1) 32400 port [tcp/*] succeeded!
[ls.io-init] done.
Critical: libusb_init failed

[github-actions]

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

[aptalca]

Oops, those should be -n, not -z

[thespad]

My bad, I've pushed a fix, should build in the next few minutes

[anderspede]

Thanks for the super fast response, that did the trick! 👍🏻