#1030 Tweetinvi is now using DateTimeOffset instead of DateTime

Author: linvi

Tests/xUnitinvi/EndToEnd/AuthEndToEndTests.cs

@@ -99,7 +99,7 @@ public async Task AuthenticateWithPinCodeAsync()
                 return;
 
             // act
-            var authenticationClient = new TwitterClient(EndToEndTestConfig.TweetinviApi.Credentials);
+            var authenticationClient = new TwitterClient(EndToEndTestConfig.TweetinviTest.Credentials);
             var authenticationRequest = await authenticationClient.Auth.RequestAuthenticationUrlAsync();
             var authUrl = authenticationRequest.AuthorizationURL;
 
@@ -191,7 +191,7 @@ private async Task<TwitterClient> GetAuthenticatedTwitterClientViaRedirectAsync(
         {
             var expectAuthRequestTask = AExtensions.HttpRequest(new AssertHttpRequestConfig(_logger.WriteLine))
                 .OnPort(8042)
-                .WithATimeoutOf(TimeSpan.FromSeconds(30))
+                .WithATimeoutOf(TimeSpan.FromSeconds(40))
                 .Matching(request => { return request.Url.AbsoluteUri.Contains(authRequest.AuthorizationKey); })
                 .MustHaveHappenedAsync();
 
@@ -265,20 +265,31 @@ private void AuthenticateOnTwitterWebsite(string authUrl, RemoteWebDriver webDri
 
             Task.Delay(2000).Wait();
 
-            var emailTextFields = webDriver.FindElementsByClassName("js-username-field");
-            // var emailTextFields = webDriver.FindElements(By.Name("session[username_or_email]"));
+            // var emailTextFields = webDriver.FindElementsByClassName("js-username-field");
+
+            var emailTextFields = webDriver.FindElements(By.Name("session[username_or_email]"));
             var isTwitterPromptingForSecondAuthentication = emailTextFields.Count == 1;
 
+            // NOTE : If this appears to redirect to twitter.com instead of the redirect page
+            // It means that Twitter detected strange action. Need to authenticate and share access code
+
             if (isTwitterPromptingForSecondAuthentication)
             {
-                var secondPasswordTextField = webDriver.FindElementByClassName("js-password-field");
-                // var secondPasswordTextField = webDriver.FindElement(By.Name("session[password]"));
+                // var secondPasswordTextField = webDriver.FindElementByClassName("js-password-field");
+                var secondPasswordTextField = webDriver.FindElement(By.Name("session[password]"));
                 emailTextFields[0].SendKeys(Environment.GetEnvironmentVariable("TWEETINVI_EMAIL"));
                 secondPasswordTextField.SendKeys(Environment.GetEnvironmentVariable("TWEETINVI_PASS"));
                 secondPasswordTextField.Submit();
                 new WebDriverWait(webDriver, TimeSpan.FromSeconds(10)).Until(d => ((IJavaScriptExecutor) d).ExecuteScript("return document.readyState").Equals("complete"));
             }
 
+            var currentUrl = webDriver.Url;
+            if (currentUrl.Contains("twitter"))
+            {
+                webDriver.Url = authUrl;
+                new WebDriverWait(webDriver, TimeSpan.FromSeconds(10)).Until(d => ((IJavaScriptExecutor) d).ExecuteScript("return document.readyState").Equals("complete"));
+            }
+
             _logger.WriteLine($"{DateTime.Now.ToLongTimeString()} - authentication completed");
         }
 

Tests/xUnitinvi/EndToEnd/StreamEndToEndTests.cs

@@ -151,7 +151,7 @@ public async Task FilteredStream_UrlMatching()
             }
 
             Assert.Equal(matchedTweetEvent.MatchOn, MatchOn.URLEntities);
-            Assert.True(matchedTweetEvent.MatchOn == MatchOn.URLEntities|| matchedTweetEvent.QuotedTweetMatchOn == MatchOn.URLEntities);
+            Assert.True(matchedTweetEvent.MatchOn == MatchOn.URLEntities || matchedTweetEvent.QuotedTweetMatchOn == MatchOn.URLEntities);
 
             await Task.Delay(TimeSpan.FromSeconds(10)); // this is for preventing Enhance Your Calm message from Twitter
         }
@@ -191,7 +191,7 @@ public async Task FilteredStream_UserMentionsMatching()
                 throw new TimeoutException();
             }
 
-            Assert.True(matchedTweetEvent.MatchOn == (MatchOn.TweetText | MatchOn.UserMentionEntities) || matchedTweetEvent.QuotedTweetMatchOn == (MatchOn.TweetText | MatchOn.UserMentionEntities));
+            Assert.Equal(matchedTweetEvent.MatchOn | matchedTweetEvent.QuotedTweetMatchOn | matchedTweetEvent.RetweetMatchOn, MatchOn.TweetText | MatchOn.UserMentionEntities);
 
             await Task.Delay(TimeSpan.FromSeconds(20)); // this is for preventing Enhance Your Calm message from Twitter
         }
@@ -232,7 +232,7 @@ public async Task FilteredStream_HashtagsMatching()
                 throw new TimeoutException();
             }
 
-            Assert.True(matchedTweetEvent.MatchOn == (MatchOn.TweetText | MatchOn.HashTagEntities) || matchedTweetEvent.QuotedTweetMatchOn == (MatchOn.TweetText | MatchOn.HashTagEntities));
+            Assert.Equal(matchedTweetEvent.MatchOn | matchedTweetEvent.QuotedTweetMatchOn | matchedTweetEvent.RetweetMatchOn, MatchOn.TweetText | MatchOn.HashTagEntities);
 
             await Task.Delay(TimeSpan.FromSeconds(10)); // this is for preventing Enhance Your Calm message from Twitter
         }
@@ -274,7 +274,7 @@ public async Task FilteredStream_CurrencyMatching()
                 throw new TimeoutException();
             }
 
-            Assert.Equal(matchedTweetEvent.MatchOn, MatchOn.TweetText | MatchOn.SymbolEntities);
+            Assert.Equal(matchedTweetEvent.MatchOn | matchedTweetEvent.RetweetMatchOn, MatchOn.TweetText | MatchOn.SymbolEntities);
 
             await Task.Delay(TimeSpan.FromSeconds(10)); // this is for preventing Enhance Your Calm message from Twitter
         }

Tests/xUnitinvi/Streams/AccountActivityStreamTests.cs

@@ -80,7 +80,7 @@ public void TweetDeletedRaised()
             Assert.Equal(eventsReceived[0].UserId, 3198576760);
             Assert.Equal(eventsReceived[0].TweetId, 601430178305220608);
             var time = TimeSpan.FromMilliseconds(1432228155593);
-            Assert.Equal(eventsReceived[0].EventDate, new DateTime(1970, 1, 1) + time);
+            Assert.Equal(eventsReceived[0].EventDate, new DateTime(1970, 1, 1, 0, 0, 0 , DateTimeKind.Utc) + time);
         }
 
         [Fact]

src/Tweetinvi.Controllers/Messages/MessageQueryGenerator.cs

@@ -1,4 +1,5 @@
-using System.Net.Http;
+using System;
+using System.Net.Http;
 using System.Text;
 using Tweetinvi.Controllers.Properties;
 using Tweetinvi.Controllers.Shared;
@@ -85,6 +86,7 @@ private ICreateMessageDTO GetPublishMessageBody(IPublishMessageParameters parame
                 MessageEvent = new MessageEventDTO
                 {
                     Type = EventType.MessageCreate,
+                    CreatedAt = new DateTimeOffset(2000, 11, 22, 0,0,0, TimeSpan.Zero),
                     MessageCreate = new MessageCreateDTO
                     {
                         Target = new MessageCreateTargetDTO

src/Tweetinvi.Core/Core/DTO/Events/MessageEventDTO.cs

@@ -18,7 +18,7 @@ public class MessageEventDTO : IMessageEventDTO
 
         [JsonProperty("created_timestamp")]
         [JsonConverter(typeof(JsonPropertyConverterRepository))]
-        public DateTime CreatedAt { get; set; }
+        public DateTimeOffset CreatedAt { get; set; }
 
         [JsonProperty("initiated_via")]
         [JsonConverter(typeof(JsonPropertyConverterRepository))]

src/Tweetinvi.Core/Core/DTO/SavedSearchDTO.cs

@@ -21,6 +21,6 @@ public class SavedSearchDTO : ISavedSearchDTO
 
         [JsonProperty("created_at")]
         [JsonConverter(typeof(JsonPropertyConverterRepository))]
-        public DateTime CreatedAt { get; set; }
+        public DateTimeOffset CreatedAt { get; set; }
     }
 }

src/Tweetinvi.Core/Core/DTO/TweetDTO.cs

@@ -57,8 +57,8 @@ public class TweetDTO : ITweetDTO
         public ITweetEntities Entities { get; set; }
 
         [JsonProperty("created_at")]
-        [JsonConverter(typeof(JsonTwitterDateTimeConverter))]
-        public DateTime CreatedAt { get; set; }
+        [JsonConverter(typeof(JsonTwitterDateTimeOffsetConverter))]
+        public DateTimeOffset CreatedAt { get; set; }
 
         [JsonProperty("truncated")]
         public bool Truncated { get; set; }

src/Tweetinvi.Core/Core/DTO/TwitterListDTO.cs

@@ -34,8 +34,8 @@ public class TwitterListDTO : ITwitterListDTO
         public IUserDTO Owner { get; set; }
 
         [JsonProperty("created_at")]
-        [JsonConverter(typeof(JsonTwitterDateTimeConverter))]
-        public DateTime CreatedAt { get; set; }
+        [JsonConverter(typeof(JsonTwitterDateTimeOffsetConverter))]
+        public DateTimeOffset CreatedAt { get; set; }
 
         [JsonProperty("uri")]
         public string Uri { get; set; }

src/Tweetinvi.Core/Core/DTO/UploadedMediaInfo.cs

@@ -13,7 +13,7 @@ public UploadedMediaInfo()
         }
 
         [JsonIgnore]
-        public DateTime CreatedDate { get; }
+        public DateTimeOffset CreatedDate { get; }
 
         [JsonProperty("media_id")]
         public long MediaId { get; set; }

src/Tweetinvi.Core/Core/DTO/UserDTO.cs

@@ -22,8 +22,8 @@ public class UserDTO : UserIdentifierDTO, IUserDTO
         public string Description { get; set; }
 
         [JsonProperty("created_at")]
-        [JsonConverter(typeof(JsonTwitterDateTimeConverter))]
-        public DateTime CreatedAt { get; set; }
+        [JsonConverter(typeof(JsonTwitterDateTimeOffsetConverter))]
+        public DateTimeOffset CreatedAt { get; set; }
 
         [JsonProperty("location")]
         public string Location { get; set; }

src/Tweetinvi.Core/Core/DTO/Webhooks/WebhookDTO.cs

@@ -29,7 +29,7 @@ public Uri Uri
         public bool Valid { get; set; }
 
         [JsonProperty("created_timestamp")]
-        [JsonConverter(typeof(JsonTwitterDateTimeConverter), "yyyy-MM-dd HH:mm:ss zzzz")]
-        public DateTime CreatedAt { get; set; }
+        [JsonConverter(typeof(JsonTwitterDateTimeOffsetConverter), "yyyy-MM-dd HH:mm:ss zzzz")]
+        public DateTimeOffset CreatedAt { get; set; }
     }
 }

src/Tweetinvi.Core/Core/Exceptions/ITwitterException.cs

@@ -11,7 +11,7 @@ public interface ITwitterException
         string URL { get; }
         int StatusCode { get; }
         string TwitterDescription { get; }
-        DateTime CreationDate { get; }
+        DateTimeOffset CreationDate { get; }
         ITwitterExceptionInfo[] TwitterExceptionInfos { get; }
         ITwitterQuery TwitterQuery { get; }
     }

src/Tweetinvi.Core/Core/JsonConverters/JsonPropertyConverterRepository.cs

@@ -46,13 +46,15 @@ private static void IntializeClassicalTypesConverters()
             var nullableIntegerConverter = new JsonTwitterNullableConverter<int>();
             var nullableDoubleConverter = new JsonTwitterNullableConverter<double>();
             var dateTimeConverter = new JsonTwitterDateTimeConverter();
+            var dateTimeOffsetConverter = new JsonTwitterDateTimeOffsetConverter();
 
             JsonConverters.Add(typeof(bool), nullableBoolConverter);
             JsonConverters.Add(typeof(long), nullableLongConverter);
             JsonConverters.Add(typeof(long?), nullableLongConverter);
             JsonConverters.Add(typeof(int), nullableIntegerConverter);
             JsonConverters.Add(typeof(double), nullableDoubleConverter);
             JsonConverters.Add(typeof(DateTime), dateTimeConverter);
+            JsonConverters.Add(typeof(DateTimeOffset), dateTimeOffsetConverter);
         }
 
         private static void InitializeTweetinviObjectConverters()

src/Tweetinvi.Core/Core/JsonConverters/JsonTwitterDateTimeOffsetConverter.cs

@@ -0,0 +1,61 @@
+using System;
+using System.Globalization;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
+
+namespace Tweetinvi.Core.JsonConverters
+{
+    public class JsonTwitterDateTimeOffsetConverter : DateTimeConverterBase
+    {
+        private readonly string _format;
+
+        public JsonTwitterDateTimeOffsetConverter() : this("ddd MMM dd HH:mm:ss zzzz yyyy")
+        {
+        }
+
+        // ReSharper disable once MemberCanBePrivate.Global -- This is used by JsonConverters
+        public JsonTwitterDateTimeOffsetConverter(string format)
+        {
+            _format = format;
+        }
+
+        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
+        {
+            serializer.Serialize(writer, value);
+        }
+
+        public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
+        {
+            if (reader.Value is DateTimeOffset)
+            {
+                return reader.Value;
+            }
+
+            if (reader.Value is DateTime)
+            {
+                return new DateTimeOffset((DateTime)reader.Value);
+            }
+
+            var datetimeStr = reader.Value as string;
+            DateTimeOffset datetime;
+
+            // Some endpoints now return a UNIX epoch (in milliseconds) as the timestamp, so check for that
+            if (long.TryParse(datetimeStr, out long epoch))
+            {
+                var dtOffset = DateTimeOffset.FromUnixTimeMilliseconds(epoch);
+                datetime = dtOffset.LocalDateTime;
+            }
+            else // Otherwise it's a formatted string
+            {
+                datetime = DateTimeOffset.ParseExact(datetimeStr, _format, CultureInfo.InvariantCulture);
+            }
+
+            return datetime;
+        }
+
+        public override bool CanConvert(Type objectType)
+        {
+            return objectType == typeof(DateTimeOffset) || objectType == typeof(DateTimeOffset?);
+        }
+    }
+}

src/Tweetinvi.Core/Core/Models/CredentialsRateLimits.cs

@@ -17,7 +17,7 @@ public CredentialsRateLimits(CredentialsRateLimitsDTO credentialsRateLimitsDTO)
             CredentialsRateLimitsDTO = credentialsRateLimitsDTO;
         }
 
-        public DateTime CreatedAt { get; }
+        public DateTimeOffset CreatedAt { get; }
 
         public string RateLimitContext
         {

src/Tweetinvi.Core/Core/Models/EndpointRateLimit.cs

@@ -62,7 +62,7 @@ public double ResetDateTimeInSeconds
         /// DateTime when the endpoint rate limit will be reset.
         /// </summary>
         [JsonIgnore]
-        public DateTime ResetDateTime { get; private set; }
+        public DateTimeOffset ResetDateTime { get; private set; }
 
         public bool IsCustomHeaderRateLimit { get; set; }
 

src/Tweetinvi.Core/Core/Models/GetTrendsAtResult.cs

@@ -9,11 +9,11 @@ public class GetTrendsAtResult : IGetTrendsAtResult
     {
         [JsonProperty("as_of")]
         [JsonConverter(typeof(JsonPropertyConverterRepository))]
-        public DateTime AsOf { get; set; }
+        public DateTimeOffset AsOf { get; set; }
 
         [JsonProperty("created_at")]
         [JsonConverter(typeof(JsonPropertyConverterRepository))]
-        public DateTime CreatedAt { get; set; }
+        public DateTimeOffset CreatedAt { get; set; }
 
         [JsonProperty("locations")]
         public IWoeIdLocation[] WoeIdLocations { get; set; }

src/Tweetinvi.Core/Core/Models/Message.cs

@@ -45,7 +45,7 @@ public IApp App
 
         public long Id => MessageEventDTO.Id;
 
-        public DateTime CreatedAt => MessageEventDTO.CreatedAt;
+        public DateTimeOffset CreatedAt => MessageEventDTO.CreatedAt;
 
         public long SenderId => MessageEventDTO.MessageCreate.SenderId;
 

src/Tweetinvi.Core/Core/Models/SavedSearch.cs

@@ -35,6 +35,6 @@ public string Query
             set => _savedSearchDTO.Query = value;
         }
 
-        public DateTime CreatedAt => _savedSearchDTO.CreatedAt;
+        public DateTimeOffset CreatedAt => _savedSearchDTO.CreatedAt;
     }
 }

src/Tweetinvi.Core/Core/Models/Tweet.cs

@@ -145,7 +145,7 @@ public ICoordinates Coordinates
 
         public ITweetIdentifier CurrentUserRetweetIdentifier => _tweetDTO.CurrentUserRetweetIdentifier;
 
-        public DateTime CreatedAt => _tweetDTO.CreatedAt;
+        public DateTimeOffset CreatedAt => _tweetDTO.CreatedAt;
 
         public string Source
         {

src/Tweetinvi.Core/Core/Models/TwitterList.cs

@@ -43,7 +43,7 @@ public ITwitterListDTO TwitterListDTO
         public string Name => _twitterListDTO.Name;
         public string FullName => _twitterListDTO.FullName;
         public IUser Owner => _owner;
-        public DateTime CreatedAt => _twitterListDTO.CreatedAt;
+        public DateTimeOffset CreatedAt => _twitterListDTO.CreatedAt;
         public string Uri => _twitterListDTO.Uri;
         public string Description => _twitterListDTO.Description;
         public bool Following => _twitterListDTO.Following;

src/Tweetinvi.Core/Core/Models/User.cs

@@ -51,7 +51,7 @@ public string ScreenName
 
         public ITweetDTO Status => UserDTO.Status;
 
-        public DateTime CreatedAt => UserDTO.CreatedAt;
+        public DateTimeOffset CreatedAt => UserDTO.CreatedAt;
 
         public string Location => UserDTO.Location;
 

src/Tweetinvi.Core/Core/Models/Webhook.cs

@@ -18,7 +18,7 @@ public Webhook(IWebhookDTO dto)
         public string Id => WebhookDTO.Id;
         public string Url => WebhookDTO.Url;
         public bool Valid => WebhookDTO.Valid;
-        public DateTime CreatedAt => WebhookDTO.CreatedAt;
+        public DateTimeOffset CreatedAt => WebhookDTO.CreatedAt;
         public Uri Uri => WebhookDTO.Uri;
     }
 }

src/Tweetinvi.Core/Public/Events/AccountActivity/AccountActivityEvent.cs

@@ -13,7 +13,7 @@ public AccountActivityEvent()
         }
 
         public long AccountUserId { get; set; }
-        public DateTime EventDate { get; set; }
+        public DateTimeOffset EventDate { get; set; }
         public string Json { get; set; }
     }
 

src/Tweetinvi.Core/Public/Events/AccountActivity/BaseAccountActivityEventArgs.cs

@@ -19,7 +19,7 @@ protected BaseAccountActivityEventArgs(AccountActivityEvent activityEvent)
         /// <summary>
         /// The date when the event has occurred
         /// </summary>
-        public DateTime EventDate { get; }
+        public DateTimeOffset EventDate { get; }
 
         /// <summary>
         /// The full json message from which this event has been extracted out.

src/Tweetinvi.Core/Public/Events/AfterExecutingQueryEventArgs.cs

@@ -34,7 +34,7 @@ public AfterExecutingQueryEventArgs(
         /// <summary>
         /// Exact DateTime when the request completed.
         /// </summary>
-        public DateTime CompletedDateTime { get; set; }
+        public DateTimeOffset CompletedDateTime { get; set; }
 
         /// <summary>
         /// Whether the request has been successful.

src/Tweetinvi.Core/Public/Events/QueryAwaitingEventArgs.cs

@@ -23,7 +23,7 @@ public QueryAwaitingEventArgs(
         public string Query => _query;
         public IEndpointRateLimit QueryRateLimit => _queryRateLimit;
         public IReadOnlyTwitterCredentials Credentials => _twitterCredentials;
-        public DateTime ResetDateTime => _queryRateLimit.ResetDateTime;
+        public DateTimeOffset ResetDateTime => _queryRateLimit.ResetDateTime;
         public int ResetInMilliseconds => (int)_queryRateLimit.ResetDateTimeInMilliseconds;
     }
 }