Merge branch 'main' into pv-2023-11-react-maps

Author: vellip

.github/workflows/django.yml

@@ -22,13 +22,13 @@ jobs:
           --health-timeout 5s
           --health-retries 5
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: '3.8'
       - name: Setup Node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: '18.x'
       - name: Setup Postgres
@@ -39,7 +39,7 @@ jobs:
           psql -c 'create database django;' -U postgres
           psql -c 'create database django_test;' -U postgres
       - name: Cache node modules
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules
         with:
@@ -50,7 +50,7 @@ jobs:
             ${{ runner.os }}-build-
             ${{ runner.os }}-
       - name: Cache pip packages
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         env:
           cache-name: cache-pip-packages
         with:
@@ -83,8 +83,3 @@ jobs:
       - name: Run Frontend Tests
         run: |
           npm test
-      - name: Frontend Coverage
-        uses: artiomtr/[email protected]
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-        if: github.event_name == 'pull_request'

.husky/pre-commit

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 make lint-quick

adhocracy4/dashboard/mixins.py

@@ -1,9 +1,12 @@
+import warnings
 from copy import deepcopy
+from pathlib import Path
 
 from django.apps import apps
 from django.conf import settings
 from django.contrib import messages
 from django.core.exceptions import PermissionDenied
+from django.core.files.base import ContentFile
 from django.shortcuts import get_object_or_404
 from django.shortcuts import redirect
 from django.urls import NoReverseMatch
@@ -107,29 +110,61 @@ def get_context_data(self, **kwargs):
 
 
 class DashboardComponentFormSignalMixin(edit.FormMixin):
+    """Mixin which sends a project_component_updated or module_component_updated signal
+    when creating, updating or deleting an object via the HTTP POST method
+    (e.g. from the dashboard).
+    """
+
     def form_valid(self, form):
+        # The call to super.form_valid() may delete self.project or self.module,
+        # to be able to still reference them below we need to store them in separate
+        # variables before they are deleted.
+        project = self.project
+        module = self.module
+
         response = super().form_valid(form)
 
         component = self.component
         if component.identifier in components.projects:
             signals.project_component_updated.send(
                 sender=component.__class__,
-                project=self.project,
+                project=project,
                 component=component,
                 user=self.request.user,
             )
         else:
             signals.module_component_updated.send(
                 sender=component.__class__,
-                module=self.module,
+                module=module,
                 component=component,
                 user=self.request.user,
             )
         return response
 
 
 class DashboardComponentDeleteSignalMixin(edit.DeletionMixin):
+    """Deprecated, use DashboardComponentFormSignalMixin for POST requests instead.
+    This mixin will be removed in the next version.
+    """
+
+    def __init__(self):
+        warnings.warn(
+            "dashboard.mixins.DashboardComponentDeleteSignalMixin is deprecated, "
+            "use dashboard.mixins.DashboardComponentFormSignalMixin for forms / POST "
+            "requests. This mixin will be removed in the next version.",
+            DeprecationWarning,
+        )
+
+        super().__init__()
+
     def delete(self, request, *args, **kwargs):
+        warnings.warn(
+            "dashboard.mixins.DashboardComponentDeleteSignalMixin.delete()"
+            "is deprecated, use dashboard.mixins.DashboardComponentFormSignalMixin "
+            "for forms / POST requests. This mixin will be removed in the next "
+            "version.",
+            DeprecationWarning,
+        )
         # Project and module have to be stored before delete is called as
         # they may rely on the still existing db object.
         project = self.project
@@ -167,16 +202,31 @@ def post(self, request, *args, **kwargs):
 
             project_clone = deepcopy(project)
             project_clone.pk = None
-            if project_clone.tile_image:
-                project_clone.tile_image.save(
-                    project.tile_image.name, project.tile_image, False
-                )
-            if project_clone.image:
-                project_clone.image.save(project.image.name, project.image, False)
             project_clone.created = timezone.now()
             project_clone.is_draft = True
             project_clone.is_archived = False
+
+            if project.tile_image:
+                # django's image.name contains the file storage location defined in 'upload_to'
+                tile_file_name = Path(
+                    project.tile_image.name
+                ).name  # retreives only the filename
+                tile_copy = ContentFile(
+                    project.tile_image.read()
+                )  # retreives the image bytes
+                project_clone.tile_image.save(tile_file_name, tile_copy, False)
+
+            if project.image:
+                # django's image.name contains the file storage location defined in 'upload_to'
+                image_file_name = Path(project.image.name).name
+                image_copy = ContentFile(project.image.read())
+                project_clone.image.save(image_file_name, image_copy, False)
+
             project_clone.save()
+            if project.topics:
+                for topic in project.topics.all():
+                    project_clone.topics.add(topic)
+
             signals.project_created.send(
                 sender=None, project=project_clone, user=self.request.user
             )

adhocracy4/forms/fields.py

@@ -12,7 +12,7 @@ def __init__(
     ):
         label = kwargs.get("label", None)
         time_label = ""
-        if type(label) == tuple:
+        if isinstance(label, tuple):
             date_label, time_label = label
             kwargs["label"] = date_label
         elif label:

adhocracy4/phases/contents.py

@@ -1,5 +1,4 @@
 class PhaseContent:
-
     features = {}
 
     @property
@@ -17,7 +16,7 @@ class PhaseContents:
     _registry = {}
 
     def __getitem__(self, identifier):
-        if type(identifier) != str:
+        if not isinstance(identifier, str):
             raise TypeError("Phase identifier must be str")
         return self._registry[identifier]
 

adhocracy4/polls/exports.py

@@ -20,7 +20,6 @@ class PollCommentExportView(
     export_mixins.CommentExportWithRepliesToMixin,
     export_views.BaseItemExportView,
 ):
-
     model = Comment
 
     fields = ["id", "comment", "created"]
@@ -47,7 +46,6 @@ def raise_exception(self):
 
 
 class PollExportView(PermissionRequiredMixin, export_views.BaseItemExportView):
-
     permission_required = "a4polls.change_poll"
 
     def get_permission_object(self):
@@ -112,7 +110,7 @@ def get_field_data(self, item, field):
 
         else:
             field_object, is_text_field = field
-            if type(field_object) == poll_models.Choice:
+            if isinstance(field_object, poll_models.Choice):
                 votes_qs = poll_models.Vote.objects.filter(
                     choice=field_object, creator=user
                 )

adhocracy4/projects/models.py

@@ -177,7 +177,7 @@ def get_module_cluster_index(self, module):
         for idx, val in enumerate(self.participation_dates):
             if "modules" in val and module in val["modules"]:
                 return idx
-        if self.project.get_current_participation_date():
+        if hasattr(self, "project") and self.project.get_current_participation_date():
             return self.project.get_current_participation_date()
         return 0
 

changelog/1521.md

@@ -0,0 +1,3 @@
+## Fixed 
+
+- delete logic moved to form_valid method after django upgrade in dashboard component mixin

changelog/1527.md

@@ -0,0 +1,3 @@
+### Fixed
+
+- duplicated image path when a project gets duplicated in the dashboard

changelog/1528.md

@@ -0,0 +1,3 @@
+### Added
+
+- retreival of image name to save as new image instance when project is duplicated