Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test at the end of CI #26

Closed
oliverbarnes opened this issue Jul 13, 2020 · 5 comments
Closed

Add smoke test at the end of CI #26

oliverbarnes opened this issue Jul 13, 2020 · 5 comments
Assignees

Comments

@oliverbarnes
Copy link
Member

No description provided.

@jinjagit
Copy link
Member

jinjagit commented Jul 30, 2020

Add smoke test action to on_push.yml CI, after deploy action

@oliverbarnes
Copy link
Member Author

we can reuse both the smoke tests and api release teardown script, so all that needs to be added is the smoke test action to on_push.yml here

@jinjagit
Copy link
Member

jinjagit commented Jul 31, 2020

We don't want to test the create org / delete org functions? We just want to test that the api still works after an auth deploy, since the auth service must be working for the api to be working, right?

@oliverbarnes
Copy link
Member Author

oliverbarnes commented Jul 31, 2020

We don't want to test the create org / delete org functions?

No, these aren't accessible via API requests, they're internal to the service - orgs are created manually via kubectl, currently. And tested in unit tests. Eventually we might have self-signup via web interface (#10)

We just want to test that the api still works after an auth deploy, since the auth service must be working for the api to be working, right?

Exactly 👍 hence the same smoke tests

@jinjagit
Copy link
Member

Gotcha. Should be relatively easy then (famous last words, I know)

@jinjagit jinjagit self-assigned this Jul 31, 2020
This was referenced Jul 31, 2020
oliverbarnes added a commit that referenced this issue Oct 15, 2020
Co-authored-by: Oliver Azevedo Barnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants