Skip to content

Commit b8e2b2e

Browse files
author
Arthur Evans
authored
Address feedback. Fixes #821. (#834)
* Address feedback. Fixes #821. * Missed one.
1 parent fd191e9 commit b8e2b2e

File tree

13 files changed

+21
-23
lines changed

13 files changed

+21
-23
lines changed

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/00/before/my-element.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@ export class MyElement extends LitElement {
1616

1717
render() {
1818
return html`
19-
<button @click=${this.flipCoin}>Flip a coin!</button>
20-
<p>Result: ${this.result}</p>
21-
19+
<button @click=${this.flipCoin}>Flip a coin!</button>
20+
<p>Result: ${this.result}</p>
2221
`;
2322
}
2423
}

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/01/after/my-element.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ export class MyElement extends LitElement {
1616

1717
render() {
1818
return html`
19-
<button @click=${this.flipCoin}>Flip a coin!</button>
20-
<p>Result: ${this.result}</p>
19+
<button @click=${this.flipCoin}>Flip a coin!</button>
20+
<p>Result: ${this.result}</p>
2121
`;
2222
}
2323
}

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/01/before/my-element.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@ export class MyElement extends LitElement {
1717

1818
render() {
1919
return html`
20-
<button @click=${this.flipCoin}>Flip a coin!</button>
21-
<p>Result: ${this.result}</p>
22-
20+
<button @click=${this.flipCoin}>Flip a coin!</button>
21+
<p>Result: ${this.result}</p>
2322
`;
2423
}
2524
}

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/01/before/my-element.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@ export class MyElement extends LitElement {
1515

1616
render() {
1717
return html`
18-
<button @click=${this.flipCoin}>Flip a coin!</button>
19-
<p>Result: ${this.result}</p>
20-
18+
<button @click=${this.flipCoin}>Flip a coin!</button>
19+
<p>Result: ${this.result}</p>
2120
`;
2221
}
2322
}

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/02/after/my-element.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ export class MyElement extends LitElement {
1515

1616
render() {
1717
return html`
18-
${map(this.groceries, (item) =>
19-
html`<button @click=${() => this.removeItem(item)}>x</button> ${item}<br>`
18+
${map(this.groceries, (item) =>
19+
html`<button @click=${() => this.removeItem(item)}>x</button> ${item}<br>`
2020
)}
2121
`;
2222
}

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/02/before/my-element.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ export class MyElement extends LitElement {
1414

1515
render() {
1616
return html`
17-
${map(this.groceries, (item) =>
18-
html`<button @click=${() => this.removeItem(item)}>x</button> ${item}<br>`
17+
${map(this.groceries, (item) =>
18+
html`<button @click=${() => this.removeItem(item)}>x</button> ${item}<br>`
1919
)}
2020
`;
2121
}

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/04/after/my-element.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ export class MyElement extends LitElement {
3131
<label>Backward: <input id="backward" @input=${this.onInput} .value=${this.backward}></label>
3232
<div>Forward text: ${this.forward}</div>
3333
<div>Backward text: ${this.backward}</div>
34-
`
34+
`;
3535
}
3636
}

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/04/before/my-element.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ export class MyElement extends LitElement {
2121
<label>Backward: <input id="backward" @input=${this.onInput} .value=${this.backward}></label>
2222
<div>Forward text: ${this.forward}</div>
2323
<div>Backward text: ${this.backward}</div>
24-
`
24+
`;
2525
}
2626
}

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/05/after/my-element.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export class MyElement extends LitElement {
3333
if (changedProperties.has('_showMessage')) {
3434
const final = this._message.getBoundingClientRect().width;
3535
const starting = 0 - final;
36-
var player = this._message.animate([
36+
this._message.animate([
3737
{ transform: `translateX(${starting}px)` },
3838
{ transform: `translateX(0)` }
3939
], {

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/05/before/my-element.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class MyElement extends LitElement {
1818
_showMessage = false;
1919

2020
@query('#message')
21-
_message!: HTMLParagraphElement;
21+
_message!: HTMLDivElement;
2222

2323
render() {
2424
return html`

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/06/before/bye-element.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class ByeElement extends LitElement {
1818
_showMessage = false;
1919

2020
@query('#message')
21-
_message!: HTMLParagraphElement;
21+
_message!: HTMLDivElement;
2222

2323
render() {
2424
return html`
@@ -28,11 +28,12 @@ export class ByeElement extends LitElement {
2828
</div>
2929
`;
3030
}
31+
3132
protected updated(changedProperties: PropertyValues<this>): void {
3233
if (changedProperties.has('_showMessage')) {
3334
const rect = this._message.getBoundingClientRect();
3435
const startingX = 0 - rect.width;
35-
var player = this._message.animate([
36+
this._message.animate([
3637
{ transform: `translateX(${startingX}px) scale(0.1)` },
3738
{ transform: `translateX(0) translateY(0) scale(1)` }
3839
], {

Diff for: packages/lit-dev-content/samples/tutorials/reactivity/tutorial.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
},
3232
{
3333
"title": "Recap",
34-
"hasAfter": true
34+
"noSolve": true
3535
}
3636
]
3737
}

Diff for: packages/lit-dev-content/site/tutorials/content/reactivity/05.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Add the following `updated()` method to the component:
2727
if (changedProperties.has('_showMessage')) {
2828
const final = this._message.getBoundingClientRect().width;
2929
const starting = 0 - final;
30-
var player = this._message.animate([
30+
this._message.animate([
3131
{ transform: `translateX(${starting}px)` },
3232
{ transform: `translateX(0)` }
3333
], {

0 commit comments

Comments
 (0)