Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Excon (and other libs) #3

Open
johnnyshields opened this issue Jan 25, 2017 · 1 comment
Open

Support for Excon (and other libs) #3

johnnyshields opened this issue Jan 25, 2017 · 1 comment

Comments

@johnnyshields
Copy link

johnnyshields commented Jan 25, 2017

Would you accept a PR which adds the following:

Excon.defaults[:ssl_ca_file] = NetHttpSslFix::LOCAL_CA_FILE if defined?(Excon)

(Possibly consider renaming this lib to ruby_ssl_fix)

Ruby has a bazillion HTTP interaction libraries--Faraday, Excon, HTTPClient, etc. (since the std lib Net::HTTP API is not so good many people have decided to reinvent the wheel) and they all fall victim to a similar problem.

@chrisdpeters
Copy link
Member

I am going back and forth on this. I initially set out just to fix Net::HTTP, but I can see the value in using this same package for other libraries.

I guess having a few extra ifs in the gem's initialization wouldn't hurt much.

I'd probably rename the gem to ssl_fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants