Fix lots of minor type errors (#14)

* fix: address type errors in platform lookup

* fix: address type errors in define(...) call type assertion

The define(...) call types say a `number` is returned for u64s, when they
should actually be `bigint`. Since this obviously won't work (a u64 is
bigger than the largest `Number.MAX_SAFE_INTEGER`), I'm pretty sure this
has got to be an error in the typings.

I think this is probably worth digging more into at some point
(ie, is this actually a thing?), because if it isn't an error in
the typings, then it's possible there are cases where there would be data
loss sometimes due to truncation.

* fix: address s/listError/liftError/ typo

* feat: make liftError return a [enumname, variant] pair so that it can be fed into UniffiError

I think I must be missing something from the react native bindgen, I
think it handles this in a much more elegant way where the error lift
step actually returns an Error subclass.

Anyway, this is also something else to look into longer term.

* fix: add back in missing asyncopts

* fix: ignore FinalizationRegistry type errors

This isn't defined on all platforms and typescript complains, however
there's a guard for this in the code so the type error produced here
isn't all that actionable.

Author: 1egoman

templates/macros.ts

@@ -4,6 +4,10 @@
 	    {{ arg.name() | typescript_var_name }}: {{ arg | typescript_type_name }}
 		{%- if !loop.last %}, {% endif -%}
 	{%- endfor -%}
+  {%- if func.is_async() -%}
+    {%- if !func.arguments().is_empty() %}, {% endif -%}
+    asyncOpts_?: { signal: AbortSignal }
+  {%- endif -%}
 {%- endmacro %}
 
 {%- macro docstring(defn, indent_level) %}

templates/node.ts

@@ -129,7 +129,7 @@
     {%- match func_def.throws_type() -%}
       {%- when Some(err) -%}
         uniffiCaller.rustCallWithError(
-          /*liftError:*/ {{err | typescript_ffi_converter_name}}.lift.bind({{err | typescript_ffi_converter_name}}),
+          /*liftError:*/ (buffer) => ["{{err | typescript_type_name}}", {{err | typescript_ffi_converter_name}}.lift(buffer)],
           /*caller:*/ (callStatus) => {
       {%- else -%}
         uniffiCaller.rustCall(
@@ -436,8 +436,8 @@ const {{ object_def.name() | typescript_ffi_object_factory_name }}: UniffiObject
   (() => {
     /// <reference lib="es2021" />
     const registry =
-      typeof globalThis.FinalizationRegistry !== 'undefined'
-        ? new globalThis.FinalizationRegistry<UnsafeMutableRawPointer>(
+      typeof (globalThis as any).FinalizationRegistry !== 'undefined'
+        ? new (globalThis as any).FinalizationRegistry(
             (heldValue: UnsafeMutableRawPointer) => {
              {{ object_def.name() | typescript_ffi_object_factory_name }}.freePointer(heldValue);
             }

templates/sys.ts

@@ -21,6 +21,7 @@ import {
   type UniffiByteArray,
   UniffiInternalError,
   uniffiCreateFfiConverterString,
+  UniffiError,
 } from 'uniffi-bindgen-react-native';
 
 const CALL_SUCCESS = 0, CALL_ERROR = 1, CALL_UNEXPECTED_ERROR = 2, CALL_CANCELLED = 3;
@@ -34,7 +35,7 @@ let libraryLoaded = false;
 function _uniffiLoad() {
   const library = "lib{{ ci.crate_name() }}";
   const { platform } = process;
-  let ext = { darwin: "dylib", win32: "dll", linux: "so" }[platform];
+  let ext = { darwin: "dylib", win32: "dll", linux: "so" }[platform as string];
   if (!ext) {
     console.warn("Unsupported platform:", platform);
     ext = "so";
@@ -93,8 +94,8 @@ class UniffiFfiRsRustCaller {
     return this.makeRustCall(caller, liftString);
   }
 
-  rustCallWithError<T>(
-    liftError: (buffer: UniffiByteArray) => Error,
+  rustCallWithError<T, ErrorEnumAndVariant extends [string, string]>(
+    liftError: (buffer: UniffiByteArray) => ErrorEnumAndVariant,
     caller: (status: JsExternal) => T,
     liftString: (bytes: UniffiByteArray) => string,
   ): T {
@@ -124,10 +125,10 @@ class UniffiFfiRsRustCaller {
     // return status;
   }
 
-  makeRustCall<T>(
+  makeRustCall<T, ErrorEnumAndVariant extends [string, string]>(
     caller: (status: JsExternal) => T,
     liftString: (bytes: UniffiByteArray) => string,
-    liftError?: (buffer: UniffiByteArray) => Error,
+    liftError?: (buffer: UniffiByteArray) => ErrorEnumAndVariant,
   ): T {
     _checkUniffiLoaded();
 
@@ -144,10 +145,10 @@ class UniffiFfiRsRustCaller {
   }
 }
 
-function uniffiCheckCallStatus(
+function uniffiCheckCallStatus<ErrorEnumAndVariant extends [string, string]>(
   callStatus: UniffiRustCallStatusStruct,
   liftString: (bytes: UniffiByteArray) => string,
-  listError?: (buffer: UniffiByteArray) => Error,
+  liftError?: (buffer: UniffiByteArray) => [string, string],
 ) {
   switch (callStatus.code) {
     case CALL_SUCCESS:
@@ -160,8 +161,9 @@ function uniffiCheckCallStatus(
         const struct = new UniffiRustBufferValue(callStatus.error_buf);
         const errorBufBytes = struct.consumeIntoUint8Array();
 
-        if (listError) {
-          throw listError(errorBufBytes);
+        if (liftError) {
+          const [enumName, errorVariant] = liftError(errorBufBytes);
+          throw new UniffiError(enumName, errorVariant);
         }
       }
       throw new UniffiInternalError.UnexpectedRustCallError();
@@ -424,7 +426,7 @@ const FFI_DYNAMIC_LIB = define({
     {%- endmatch %}
 
   {%- endfor %}
-}) as {
+}) as unknown as {
   {%- for definition in ci.ffi_definitions() %}
     {%- match definition %}