Repository navigation
Stringify with arrayFormat: comma, wrongfully encode comma in return #337
Description
Activity
This doesn't actually appear to have been fixed. The latest version still outputs
a=b%2Cc. In fact the unit test also confirms that is the current behaviour:st.equal( qs.stringify({ a: ['b', 'c', 'd'] }, { arrayFormat: 'comma' }), 'a=b%2Cc%2Cd', 'comma => comma' );
Surely this is wrong though, as it means you can't encode values that have commas in themselves?
Reacted by humkinsYou can, it will double-encode them i believe. A PR adding those as test cases would be appreciated.
Is there a workaround for this?
@andredewaard it's not clear there's anything to be worked around. A PR with failing test cases would help to quickly result in an answer or a fix.
using
{ encode: false }options to fix thisReacted by Codebex and humkinsI've just tested this, and it doesn't double encode them. Which means that currently you can't send value that contain commas when using commas for the
arrayFormat.qs.stringify({ a: ['b,c', 'd,e'] }, { arrayFormat: 'comma', encode: true }) // output: a=b%2Cc%2Cd%2Ce // decoded: a=b,c,d,e
Should this issue be re-opened or a new more-specific one started?
wrong result with stringifying
qs.stringify({ a: ['b', 'c'] }, { arrayFormat: 'comma' })return
a=b%2Ccwhen it should return
a=b,cbecause parsing
,as reserved character per RFC 3986 should split the array if we used a parser withcomma: trueoptionand
%2C(percent encoded comma) should be treated normally as text characterrelated to : #336 pr