Components fixed (#404)

Author: lloc

includes/Component/Component.php

@@ -13,28 +13,28 @@ abstract class Component {
 
 	const ALLOWED_HTML = array(
 		'form'   => array(
-			'action' => array(),
-			'method' => array(),
+			'action' => true,
+			'method' => true,
 		),
 		'label'  => array(
-			'for' => array(),
+			'for' => true,
 		),
 		'option' => array(
-			'value'    => array(),
-			'selected' => array(),
+			'value'    => true,
+			'selected' => true,
 		),
 		'select' => array(
-			'id'   => array(),
-			'name' => array(),
+			'id'   => true,
+			'name' => true,
 		),
 		'input'  => array(
-			'type'     => array(),
-			'class'    => array(),
-			'id'       => array(),
-			'name'     => array(),
-			'value'    => array(),
-			'size'     => array(),
-			'readonly' => array(),
+			'type'     => true,
+			'class'    => true,
+			'id'       => true,
+			'name'     => true,
+			'value'    => true,
+			'size'     => true,
+			'readonly' => true,
 		),
 	);
 
@@ -45,6 +45,8 @@ abstract public function render(): string;
 
 	/**
 	 * Adds our input elements to the allowed HTML elements of a post
+	 *
+	 * @return array<string, array<string, bool>>
 	 */
 	public static function get_allowed_html(): array {
 		$my_allowed = wp_kses_allowed_html( 'post' );

includes/Component/Input/Text.php

@@ -49,7 +49,7 @@ public function render(): string {
 			'<input type="text" class="regular-text" id="%1$s" name="msls[%1$s]" value="%2$s" size="%3$d"%4$s/>',
 			esc_attr( $this->key ),
 			esc_attr( $this->value ),
-			esc_attr( $this->size ),
+			$this->size,
 			$this->readonly // phpcs:ignore WordPress.Security.EscapeOutput
 		);
 	}