Merge pull request #327 from lloc/refactoring-version-2-8

Plugin Check review

Author: lloc

includes/MslsAdmin.php

@@ -308,7 +308,10 @@ public function advanced_section(): int {
 	public function rewrites_section(): int {
 		$map = array();
 		foreach ( get_post_types( array( 'public' => true ), 'objects' ) as $key => $object ) {
-			$map[ "rewrite_{$key}" ] = sprintf( __( '%s Slug', 'multisite-language-switcher' ), $object->label );
+			/* translators: %s: post type label */
+			$format = __( '%s Slug', 'multisite-language-switcher' );
+
+			$map[ "rewrite_{$key}" ] = sprintf( $format, $object->label );
 		}
 
 		return $this->add_settings_fields( $map, 'rewrites_section' );
@@ -382,14 +385,13 @@ public function reference_user() {
 		if ( count( $users ) > self::MAX_REFERENCE_USERS ) {
 			$users = array_slice( $users, 0, self::MAX_REFERENCE_USERS, true );
 
-			$message = sprintf(
-				__(
-					'Multisite Language Switcher: Collection for reference user has been truncated because it exceeded the maximum of %s users. Please, use the hook "msls_reference_users" to filter the result before!',
-					'multisite-language-switcher'
-				),
-				self::MAX_REFERENCE_USERS
+			/* translators: %s: maximum number of users */
+			$format = __(
+				'Multisite Language Switcher: Collection for reference user has been truncated because it exceeded the maximum of %s users. Please, use the hook "msls_reference_users" to filter the result before!',
+				'multisite-language-switcher'
 			);
-			trigger_error( $message );
+
+			trigger_error( sprintf( $format, self::MAX_REFERENCE_USERS ) );
 		}
 
 		echo ( new Select( 'reference_user', $users, $this->options->reference_user ) )->render();

includes/MslsAdminIcon.php

@@ -205,6 +205,7 @@ public function get_img(): string {
 	 */
 	public function get_a(): string {
 		if ( empty( $this->href ) ) {
+			/* translators: %s: blog name */
 			$format = __( 'Create a new translation in the %s-blog', 'multisite-language-switcher' );
 			$href   = $this->get_edit_new();
 		} else {