From f2bb69bdcac4351b015fdb09f6c7af4ef15e84f9 Mon Sep 17 00:00:00 2001
From: Dennis Ploetner <re@lloc.de>
Date: Tue, 4 Jun 2024 23:10:33 +0200
Subject: [PATCH] Plugin Check review

---
 includes/MslsAdminIcon.php    | 19 ++++++++-----------
 includes/MslsCustomFilter.php |  8 ++++----
 2 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/includes/MslsAdminIcon.php b/includes/MslsAdminIcon.php
index b73f0265..ca819252 100644
--- a/includes/MslsAdminIcon.php
+++ b/includes/MslsAdminIcon.php
@@ -205,20 +205,17 @@ public function get_img(): string {
 	 */
 	public function get_a(): string {
 		if ( empty( $this->href ) ) {
-			$title = sprintf(
-				__( 'Create a new translation in the %s-blog', 'multisite-language-switcher' ),
-				$this->language
-			);
-			$href  = $this->get_edit_new();
+			$format = __( 'Create a new translation in the %s-blog', 'multisite-language-switcher' );
+			$href   = $this->get_edit_new();
 		} else {
-			$title = sprintf(
-				__( 'Edit the translation in the %s-blog', 'multisite-language-switcher' ),
-				$this->language
-			);
-			$href  = $this->href;
+			/* translators: %s: blog name */
+			$format = __( 'Edit the translation in the %s-blog', 'multisite-language-switcher' );
+			$href   = $this->href;
 		}
 
-		return sprintf( '<a title="%s" href="%s">%s</a>&nbsp;', $title, $href, $this->get_icon() );
+		$title = sprintf( $format, $this->language );
+
+		return sprintf( '<a title="%1$s" href="%2$s">%3$s</a>&nbsp;', $title, $href, $this->get_icon() );
 	}
 
 	/**
diff --git a/includes/MslsCustomFilter.php b/includes/MslsCustomFilter.php
index 16b9e0d7..b0608e94 100644
--- a/includes/MslsCustomFilter.php
+++ b/includes/MslsCustomFilter.php
@@ -51,10 +51,10 @@ public function add_filter(): void {
 		if ( $blogs ) {
 			$options = array( '' => esc_html( __( 'Show all posts', 'multisite-language-switcher' ) ) );
 			foreach ( $blogs as $blog ) {
-				$options[ strval( $blog->userblog_id ) ] = sprintf(
-					__( 'Not translated in the %s-blog', 'multisite-language-switcher' ),
-					$blog->get_description()
-				);
+				/* translators: %s: blog name */
+				$format = __( 'Not translated in the %s-blog', 'multisite-language-switcher' );
+
+				$options[ strval( $blog->userblog_id ) ] = sprintf( $format, $blog->get_description() );
 			}
 
 			$id = MslsRequest::get( MslsFields::FIELD_MSLS_FILTER, 0 );