Skip to content

Commit 617cf8a

Browse files
authored
Reapply "Finish deleting the le32/le64 targets" (#99079) (#101983)
This reverts commit d3f8105. Halide no longer relies on this target: #98497 (comment)
1 parent 6e60d54 commit 617cf8a

File tree

18 files changed

+4
-157
lines changed

18 files changed

+4
-157
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ These changes are ones which we think may surprise users when upgrading to
3737
Clang |release| because of the opportunity they pose for disruption to existing
3838
code bases.
3939

40+
- The ``le32`` and ``le64`` targets have been removed.
41+
4042
C/C++ Language Potentially Breaking Changes
4143
-------------------------------------------
4244

clang/docs/tools/clang-formatted-files.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,6 @@ clang/lib/Basic/Targets/BPF.cpp
362362
clang/lib/Basic/Targets/BPF.h
363363
clang/lib/Basic/Targets/Hexagon.h
364364
clang/lib/Basic/Targets/Lanai.h
365-
clang/lib/Basic/Targets/Le64.h
366365
clang/lib/Basic/Targets/M68k.h
367366
clang/lib/Basic/Targets/MSP430.h
368367
clang/lib/Basic/Targets/NVPTX.cpp

clang/lib/Basic/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ add_clang_library(clangBasic
102102
Targets/DirectX.cpp
103103
Targets/Hexagon.cpp
104104
Targets/Lanai.cpp
105-
Targets/Le64.cpp
106105
Targets/LoongArch.cpp
107106
Targets/M68k.cpp
108107
Targets/MSP430.cpp

clang/lib/Basic/Targets.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include "Targets/DirectX.h"
2424
#include "Targets/Hexagon.h"
2525
#include "Targets/Lanai.h"
26-
#include "Targets/Le64.h"
2726
#include "Targets/LoongArch.h"
2827
#include "Targets/M68k.h"
2928
#include "Targets/MSP430.h"
@@ -344,17 +343,6 @@ std::unique_ptr<TargetInfo> AllocateTarget(const llvm::Triple &Triple,
344343
return std::make_unique<M68kTargetInfo>(Triple, Opts);
345344
}
346345

347-
case llvm::Triple::le32:
348-
switch (os) {
349-
case llvm::Triple::NaCl:
350-
return std::make_unique<NaClTargetInfo<PNaClTargetInfo>>(Triple, Opts);
351-
default:
352-
return nullptr;
353-
}
354-
355-
case llvm::Triple::le64:
356-
return std::make_unique<Le64TargetInfo>(Triple, Opts);
357-
358346
case llvm::Triple::ppc:
359347
switch (os) {
360348
case llvm::Triple::Linux:

clang/lib/Basic/Targets/Le64.cpp

Lines changed: 0 additions & 30 deletions
This file was deleted.

clang/lib/Basic/Targets/Le64.h

Lines changed: 0 additions & 64 deletions
This file was deleted.

clang/lib/Basic/Targets/OSTargets.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -841,9 +841,6 @@ class LLVM_LIBRARY_VISIBILITY NaClTargetInfo : public OSTargetInfo<Target> {
841841
"i64:64-i128:128-n8:16:32:64-S128");
842842
} else if (Triple.getArch() == llvm::Triple::mipsel) {
843843
// Handled on mips' setDataLayout.
844-
} else {
845-
assert(Triple.getArch() == llvm::Triple::le32);
846-
this->resetDataLayout("e-p:32:32-i64:64");
847844
}
848845
}
849846
};

clang/lib/CodeGen/CodeGenModule.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,6 @@ createTargetCodeGenInfo(CodeGenModule &CGM) {
116116
default:
117117
return createDefaultTargetCodeGenInfo(CGM);
118118

119-
case llvm::Triple::le32:
120-
return createPNaClTargetCodeGenInfo(CGM);
121119
case llvm::Triple::m68k:
122120
return createM68kTargetCodeGenInfo(CGM);
123121
case llvm::Triple::mips:

clang/lib/CodeGen/ItaniumCXXABI.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -582,13 +582,6 @@ CodeGen::CGCXXABI *CodeGen::CreateItaniumCXXABI(CodeGenModule &CGM) {
582582
return new XLCXXABI(CGM);
583583

584584
case TargetCXXABI::GenericItanium:
585-
if (CGM.getContext().getTargetInfo().getTriple().getArch()
586-
== llvm::Triple::le32) {
587-
// For PNaCl, use ARM-style method pointers so that PNaCl code
588-
// does not assume anything about the alignment of function
589-
// pointers.
590-
return new ItaniumCXXABI(CGM, /*UseARMMethodPtrABI=*/true);
591-
}
592585
return new ItaniumCXXABI(CGM);
593586

594587
case TargetCXXABI::Microsoft:

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3928,12 +3928,6 @@ static void RenderBuiltinOptions(const ToolChain &TC, const llvm::Triple &T,
39283928
if (UseBuiltins)
39293929
A->render(Args, CmdArgs);
39303930
}
3931-
3932-
// le32-specific flags:
3933-
// -fno-math-builtin: clang should not convert math builtins to intrinsics
3934-
// by default.
3935-
if (TC.getArch() == llvm::Triple::le32)
3936-
CmdArgs.push_back("-fno-math-builtin");
39373931
}
39383932

39393933
bool Driver::getDefaultModuleCachePath(SmallVectorImpl<char> &Result) {

0 commit comments

Comments
 (0)