Missing return statements in fill and for_each

AntonRydahl · AntonRydahl · commit 94474817194a · 2023-09-26T20:15:33.000-07:00
diff --git a/libcxx/include/__algorithm/pstl_backends/gpu_backends/fill.h b/libcxx/include/__algorithm/pstl_backends/gpu_backends/fill.h
@@ -36,7 +36,7 @@ __pstl_fill(__gpu_backend_tag, _ForwardIterator __first, _ForwardIterator __last
   if constexpr (__is_unsequenced_execution_policy_v<_ExecutionPolicy> &&
                 __has_random_access_iterator_category_or_concept<_ForwardIterator>::value &&
                 __libcpp_is_contiguous_iterator<_ForwardIterator>::value) {
-    std::__par_backend::__parallel_for_simd_val_1(__first, __last - __first, __value);
+    return std::__par_backend::__parallel_for_simd_val_1(__first, __last - __first, __value);
   }
   // Otherwise, we execute for_each on the CPU instead
   return std::__pstl_fill<_ExecutionPolicy>(__cpu_backend_tag{}, __first, __last, __value);
diff --git a/libcxx/include/__algorithm/pstl_backends/gpu_backends/for_each.h b/libcxx/include/__algorithm/pstl_backends/gpu_backends/for_each.h
@@ -35,7 +35,7 @@ __pstl_for_each(__gpu_backend_tag, _ForwardIterator __first, _ForwardIterator __
   if constexpr (__is_unsequenced_execution_policy_v<_ExecutionPolicy> &&
                 __has_random_access_iterator_category_or_concept<_ForwardIterator>::value &&
                 __libcpp_is_contiguous_iterator<_ForwardIterator>::value) {
-    std::__par_backend::__parallel_for_simd_1(__first, __last - __first, __func);
+    return std::__par_backend::__parallel_for_simd_1(__first, __last - __first, __func);
   }
   // Else if the excution policy is parallel, we execute for_each on the CPU instead
   return std::__pstl_for_each<_ExecutionPolicy>(__cpu_backend_tag{}, __first, __last, __func);

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ __pstl_fill(__gpu_backend_tag, _ForwardIterator __first, _ForwardIterator __last`
`36`	`36`	`if constexpr (__is_unsequenced_execution_policy_v<_ExecutionPolicy> &&`
`37`	`37`	`__has_random_access_iterator_category_or_concept<_ForwardIterator>::value &&`
`38`	`38`	`__libcpp_is_contiguous_iterator<_ForwardIterator>::value) {`
`39`		`- std::__par_backend::__parallel_for_simd_val_1(__first, __last - __first, __value);`
	`39`	`+ return std::__par_backend::__parallel_for_simd_val_1(__first, __last - __first, __value);`
`40`	`40`	`}`
`41`	`41`	`// Otherwise, we execute for_each on the CPU instead`
`42`	`42`	`return std::__pstl_fill<_ExecutionPolicy>(__cpu_backend_tag{}, __first, __last, __value);`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ __pstl_for_each(__gpu_backend_tag, _ForwardIterator __first, _ForwardIterator __`
`35`	`35`	`if constexpr (__is_unsequenced_execution_policy_v<_ExecutionPolicy> &&`
`36`	`36`	`__has_random_access_iterator_category_or_concept<_ForwardIterator>::value &&`
`37`	`37`	`__libcpp_is_contiguous_iterator<_ForwardIterator>::value) {`
`38`		`- std::__par_backend::__parallel_for_simd_1(__first, __last - __first, __func);`
	`38`	`+ return std::__par_backend::__parallel_for_simd_1(__first, __last - __first, __func);`
`39`	`39`	`}`
`40`	`40`	`// Else if the excution policy is parallel, we execute for_each on the CPU instead`
`41`	`41`	`return std::__pstl_for_each<_ExecutionPolicy>(__cpu_backend_tag{}, __first, __last, __func);`