Skip to content

Commit bf52884

Browse files
authored
[DomTreeUpdater] Fix use after free in unittests (#97133)
In #96851, the unit test contains use after free, which triggers sanitizer error. Fix https://lab.llvm.org/buildbot/#/builders/169/builds/490
1 parent cb24422 commit bf52884

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

llvm/unittests/CodeGen/MachineDomTreeUpdaterTest.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ body: |
179179
DTU.deleteBB(&*BB4);
180180
EXPECT_EQ(BB1->succ_size(), 1u);
181181
ASSERT_TRUE(DT.dominates(&*BB1, &*BB2));
182-
ASSERT_EQ(DT.getNode(&*BB4), nullptr);
183182
}
184183

185184
TEST_F(MachineDomTreeUpdaterTest, LazyUpdateBasicOperations) {
@@ -268,9 +267,9 @@ body: |
268267
ASSERT_TRUE(DT.dominates(&*BB1, &*BB4));
269268
BB1->removeSuccessor(&*BB4);
270269
DTU.deleteBB(&*BB4);
270+
ASSERT_TRUE(DTU.hasPendingDeletedBB());
271271
EXPECT_EQ(BB1->succ_size(), 1u);
272272
ASSERT_TRUE(DT.dominates(&*BB1, &*BB2));
273273
ASSERT_NE(DT.getNode(&*BB4), nullptr);
274274
DTU.flush();
275-
ASSERT_EQ(DT.getNode(&*BB4), nullptr);
276275
}

0 commit comments

Comments
 (0)