Skip to content

Commit f11d46c

Browse files
[Github] Remove invalid comment from pr-code-format.yaml
The comment was originally added in b3af755, but 2898c3e greatly simplified things making the previous comment invalid. We no longer need to look at diffing main versus the PR and whether we are doing a two dot or three dot diff as we are just diffing the merge commit.
1 parent 6c33735 commit f11d46c

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

.github/workflows/pr-code-format.yml

-4
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,6 @@ jobs:
7373
START_REV: ${{ github.event.pull_request.base.sha }}
7474
END_REV: ${{ github.event.pull_request.head.sha }}
7575
CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
76-
# TODO(boomanaiden154): Once clang v18 is released, we should be able
77-
# to take advantage of the new --diff_from_common_commit option
78-
# explicitly in code-format-helper.py and not have to diff starting at
79-
# the merge base.
8076
# Create an empty comments file so the pr-write job doesn't fail.
8177
run: |
8278
echo "[]" > comments &&

0 commit comments

Comments
 (0)