Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix for SubscripttonManagement servlet #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WilliamPetit
Copy link
Contributor

Proposed changes

The UpdateSubscriptions() function was considering a subsciption with
missing status parameter as a 'subscription to update to unset'.

It mainly because the getTriBoxValue function return the same thing
whether the value of the parameter is 'null' or 'unset'.

Therefore, this fix simply make sure the parameter wasn't 'null' before
updating the subscription.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Feature modification (Fix or feature that will cause existing functionality to not work as expected)

Checklist

  • Read the CONTRIBUTING doc
  • Maintained the existing coding style and format
  • Added tests that prove my fix is effective or that my feature works
  • Added necessary documentation (if appropriate)
  • Rebase and squash my commits. Submit one commit only, on top of the master branch.

Further comments

This hasn't been tested at all.

The UpdateSubscriptions() function was considering a subsciption with
missing status parameter as a 'subscription to update to unset'.

It mainly because the getTriBoxValue function return the same thing
whether the value of the parameter is 'null' or 'unset'.

Therefore, this fix simply make sure the parameter wasn't 'null' before
updating the subscription.
Copy link
Contributor

@fergaloy fergaloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this does not fix the problem. It behaves the same way as before, deleting subscriptions that are in tabs that have not been visited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants