-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Safenet serve content #7
Open
steven-cd
wants to merge
13
commits into
lockss:master
Choose a base branch
from
edina:safenet_serve_content
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enable it (org.lockss.contentui.safenet)
…led, not org.lockss.platform.project
FAO: @thibgc |
fc7491c
to
36cdc03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses various review comments received by email around the
SafeNetServeContent
class, for the purposes of the Keepsafe EU projects.An overview of the changes:
SafeNetServeContent
withEntitlementCheckServeContent
, i.e. a subclass ofServeContent
that checks whether the user is entitled to see the content, and a generalEntitlementRegistryClient
responsible for checking thatorg.lockss.platform.project = safenet
configuration is not used any more, and insteadorg.lockss.entitlement.keepsafe.enabled = true
would be used. Nobody except us would have been using that config parameterorg.lockss.safenet
are now underorg.lockss.entitlement
EntitlementRegistryClient
thread-safe (raised in Create EntitlementRegistryClient for communicating with SafeNet ER #2)EntitlementRegistryClient
(also from Create EntitlementRegistryClient for communicating with SafeNet ER #2)I can, if you wish, break this up further, and similarly could squash it into one commit, but I thought this was easier at the moment given the informal reviews we've done so far.