Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Safenet serve content #7

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

steven-cd
Copy link
Contributor

This addresses various review comments received by email around the SafeNetServeContent class, for the purposes of the Keepsafe EU projects.

An overview of the changes:

  • Making the work more generic, essentially replacing SafeNetServeContent with EntitlementCheckServeContent, i.e. a subclass of ServeContent that checks whether the user is entitled to see the content, and a general EntitlementRegistryClient responsible for checking that
  • Other references to SafeNet have been removed, and mainly replaced with Keepsafe
  • The org.lockss.platform.project = safenet configuration is not used any more, and instead org.lockss.entitlement.keepsafe.enabled = true would be used. Nobody except us would have been using that config parameter
  • Similarly, other config parameters under org.lockss.safenet are now under org.lockss.entitlement
  • Extraction of the bibliographic data necessary to check the entitlement from the metadata database, with the TDB files only used as fallback
  • Various changes to make EntitlementRegistryClient thread-safe (raised in Create EntitlementRegistryClient for communicating with SafeNet ER #2)
  • Connection pooling in EntitlementRegistryClient (also from Create EntitlementRegistryClient for communicating with SafeNet ER #2)
  • Some changes based on changes to the external Keepsafe API

I can, if you wish, break this up further, and similarly could squash it into one commit, but I thought this was easier at the moment given the informal reviews we've done so far.

@steven-cd
Copy link
Contributor Author

FAO: @thibgc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant