Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden DOI substring match to preferred resolver #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Broaden DOI substring match to preferred resolver #8

wants to merge 1 commit into from

Conversation

katrinleinweber
Copy link

Proposed changes

  1. Brief description of changes applied

The DOI foundation recommends this new, secure resolver. I was wondering whether the attached change could be used to match both the old and new resolver URLs. Or would substringAfter need to be replaced with a reg-ex matching function?

  1. Any documentation on how to configure, test
  2. Any possible limitations, side effects, etc.

Currently yes, see Further comments, but might not be, if applied everywhere.

  1. Reference any other pull requests that might be related.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Feature modification (Fix or feature that will cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Read the CONTRIBUTING doc
  • Maintained the existing coding style and format
  • Added tests that prove my fix is effective or that my feature works
  • Added necessary documentation (if appropriate)
  • Rebase and squash my commits. Submit one commit only, on top of the master branch.

Further comments

This will probably need to expand, because there are many other instances of dx.doi.org being used in reg-exes, etc.: https://github.com/lockss/lockss-daemon/search?l=Java&q=dx.doi&type=

Reviewers: @tlipkis, @clairegriffin, ...

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant