Broaden DOI substring match to preferred resolver #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The DOI foundation recommends this new, secure resolver. I was wondering whether the attached change could be used to match both the old and new resolver URLs. Or would
substringAfter
need to be replaced with a reg-ex matching function?Currently yes, see
Further comments
, but might not be, if applied everywhere.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
This will probably need to expand, because there are many other instances of
dx.doi.org
being used in reg-exes, etc.: https://github.com/lockss/lockss-daemon/search?l=Java&q=dx.doi&type=Reviewers: @tlipkis, @clairegriffin, ...
Thanks for your contribution.