Skip to content

Commit f3ad919

Browse files
authored
fix(website): separate key and label on edit page (#1410)
1 parent c508bc8 commit f3ad919

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

website/src/components/Edit/DataRow.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,17 @@ import WarningAmberIcon from '~icons/ic/baseline-warning-amber';
55
import DangerousTwoToneIcon from '~icons/ic/twotone-dangerous';
66

77
type EditableRowProps = {
8+
label?: string;
89
row: Row;
910
onChange: (editedRow: Row) => void;
1011
};
1112

12-
export const EditableDataRow: FC<EditableRowProps> = ({ row, onChange }) => {
13+
export const EditableDataRow: FC<EditableRowProps> = ({ label, row, onChange }) => {
1314
const colorClassName = row.errors.length > 0 ? 'text-red-600' : row.warnings.length > 0 ? 'text-yellow-600' : '';
1415

1516
return (
1617
<tr>
17-
<td className={`w-1/4 ${colorClassName}`}>{row.key}:</td>
18+
<td className={`w-1/4 ${colorClassName}`}>{label ?? row.key}:</td>
1819
<td className='pr-3 text-right '>
1920
<ErrorAndWarningIcons row={row} />
2021
</td>
@@ -49,12 +50,13 @@ const ErrorAndWarningIcons: FC<ErrorAndWarningIconsProps> = ({ row }) => {
4950
};
5051

5152
type ProcessedDataRowProps = {
53+
label?: string;
5254
row: KeyValuePair;
5355
};
5456

55-
export const ProcessedDataRow: FC<ProcessedDataRowProps> = ({ row }) => (
57+
export const ProcessedDataRow: FC<ProcessedDataRowProps> = ({ label, row }) => (
5658
<tr>
57-
<td className={`w-1/4 `}>{row.key}:</td>
59+
<td className={`w-1/4 `}>{label ?? row.key}:</td>
5860
<td />
5961
<td className='w-full'>
6062
<div className='px-3'>{row.value}</div>

website/src/components/Edit/EditPage.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,9 @@ const EditableOriginalData: FC<EditableOriginalDataProps> = ({ editedMetadata, s
201201
<>
202202
<Subtitle title='Metadata' />
203203
{editedMetadata.map((field) => {
204-
field.key = sentenceCase(field.key);
205204
return (
206205
<EditableDataRow
206+
label={sentenceCase(field.key)}
207207
key={'raw_metadata' + field.key}
208208
row={field}
209209
onChange={(editedRow: Row) =>
@@ -250,6 +250,7 @@ const ProcessedMetadata: FC<ProcessedMetadataProps> = ({ processedMetadata }) =>
250250
<Subtitle title='Metadata' customKey='preprocessing_metadata' />
251251
{Object.entries(processedMetadata).map(([key, value]) => (
252252
<ProcessedDataRow
253+
label={sentenceCase(key)}
253254
key={'processed' + key}
254255
row={{ key: sentenceCase(key), value: displayMetadataField(value) }}
255256
/>

0 commit comments

Comments
 (0)