-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include submissionId
in displayName
#3652
Comments
submissionId
in displayName
👍 one could treat |
(For GenSpectrum of course you could make any choice you want about what to include, which is already configurable) |
That could be one option. It will probably work well in many cases but not in all. We have in Pathoplexus https://pathoplexus.org/seq/PP_0013N8P.1 with a Submission ID "Monkeypox/PT0836/2025". If we do this, we may want to adapt our Pathoplexus submission documentation to make users aware of how the submission ID is going to be used. |
👍 there could be a general case for stripping |
Maybe the display name format could be configurable on a per-organism basis? i.e. displayNameFormat: "${sampleId}/${accession}/${version}/${collectionCountry}" The display name is mostly useful for website navigation etc, and I think depending on how one uses Loculus, different things might be useful to have in the display name (maybe one might opt to only use the sample ID and not even care about Loculus accessions or anything else!). What exactly is done for PPX can then be a separate discussion |
It already is - it's made by the preprocessing pipeline subject to configuration in the YAML. I still think this is a useful place to have the discussion as, for example, it does impact on this Q about potential specific behaviour for the |
The definitive sample ID (a la Hu-1 for SARS-CoV-2) for the recent ebola genome is CL292200, which was used as the
submissionId
.IMO we should include it in the
displayName
, which we don't currently:I expect this to apply in many future instances.
The text was updated successfully, but these errors were encountered: