-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should strip leading spaces in search queries #3655
Comments
this one works: https://main.loculus.org/ebola-sudan/search?visibility_submissionId=true&submissionId=OQ673032.1
|
This is because of a leading space in the search query when you copy-pasted (as @fhennig pointed out, you can see it in your URL) we should strip these |
@theosanderson, do we want to strip leading spaces (1) from all search queries or (2) only from those where we perform a sub-string search? (2) seems quite safe to me, but I'm not sure about (1) – what if someone does have a leading space in their data? |
Yes - good Q. I think my vote would be everything. Stripping is potentially dangerous but not stripping is also dangerous! (we might well not have set this field as substring). I think my vote would be strip everything and in 2 years when it catches someone out, implement configurability. But either would work for this case so I don't feel strongly - we could start with your idea. |
Reposting from Slack: Actually the thing that gets copied is |
This is live on production, I cannot search by submissionId - can be tried by pasting the submissionId of any sequence into search:
e.g. https://main.loculus.org/seq/LOC_000PB42.1
The text was updated successfully, but these errors were encountered: